Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New @layer implementation #13737

Closed
tugcekucukoglu opened this issue Sep 25, 2023 · 9 comments
Closed

New @layer implementation #13737

tugcekucukoglu opened this issue Sep 25, 2023 · 9 comments
Assignees
Labels
Component: Theme Issue or pull request is related to Theme Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@tugcekucukoglu
Copy link
Member

No description provided.

@tugcekucukoglu tugcekucukoglu added this to the 16.4.0 milestone Sep 25, 2023
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 25, 2023
@tugcekucukoglu tugcekucukoglu added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add Type: Breaking Change Issue contains a breaking change related to a specific component Component: Theme Issue or pull request is related to Theme and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Sep 25, 2023
@tugcekucukoglu tugcekucukoglu self-assigned this Sep 25, 2023
tugcekucukoglu added a commit that referenced this issue Sep 25, 2023
tugcekucukoglu added a commit that referenced this issue Sep 26, 2023
tugcekucukoglu added a commit that referenced this issue Sep 26, 2023
@andyg3
Copy link
Contributor

andyg3 commented Sep 26, 2023

This change has broken my jest tests. Do I need a new shim or something?
I see:

    Error: Could not parse CSS stylesheet
        at exports.createStylesheet 

and later...
detail: '@layer primeng{.p-dialog-mask{position:fixed;top:0;left:0;width:100%;height:100%;display:flex;justify-content:center;align-items:center;pointer-events:... etc.

@Adrii77
Copy link

Adrii77 commented Sep 27, 2023

Same issue here

@JLa2r
Copy link

JLa2r commented Sep 27, 2023

Also having the same issue with unit tests

@cagataycivici cagataycivici removed the Type: Breaking Change Issue contains a breaking change related to a specific component label Sep 28, 2023
@danymarques
Copy link

Same here.. Any idea to workaround this?

@Adrii77
Copy link

Adrii77 commented Oct 18, 2023

Didn't find... I'm stuck on PrimeNG 16.3 because of that. All of my snapshots tests are broken with 16.4.

@Adrii77
Copy link

Adrii77 commented Oct 26, 2023

I resolve the issue : I found this issue from primevue and I use this workaround

@Phil-DS
Copy link

Phil-DS commented Oct 26, 2023

This has been breaking my tests, and messing up the testing process. Until its properly fixed, I might have to revert to a primeng version prior to this.

The stubbing/mocking of the console.error function is still breaking the test workflow, as it's not properly going through the tests themselves.

@bendehghan
Copy link

is this being tracked with another bug? I'm also seeing this error and I'm confused why the bug is closed.

@angelo-v
Copy link

#14085

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Theme Issue or pull request is related to Theme Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

9 participants