Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility | Tabview ink bar accessibility problems #13902

Closed
GiacomoDM opened this issue Oct 17, 2023 · 0 comments · Fixed by #13923
Closed

Accessibility | Tabview ink bar accessibility problems #13902

GiacomoDM opened this issue Oct 17, 2023 · 0 comments · Fixed by #13923
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
16.6.0

Comments

@GiacomoDM
Copy link
Contributor

Describe the bug

The TabView component correctly implements an ul list with a lì item for each tab.
Inside the list, a li is appended at the end to render the ink bar that visually highlight the selected tab. This element should have role="presentation" and should be aria-hidden.

image

PrimeVue corrent implementation:
image

Environment

Windows

Reproducer

https://primeng.org/tabview

Angular version

16.X

PrimeNG version

16.5.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.16

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@GiacomoDM GiacomoDM added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 17, 2023
GiacomoDM added a commit to GiacomoDM/primeng that referenced this issue Oct 19, 2023
@GiacomoDM
Bugfix primefaces#13902 Fix TabView inkbar accessibility
a4fa782
@GiacomoDM GiacomoDM mentioned this issue Oct 19, 2023
Merged
@cetincakiroglu cetincakiroglu added this to the 16.6.0 milestone Oct 25, 2023
@cetincakiroglu cetincakiroglu added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add Component: Accessibility Issue or pull request is related to WCAG or ARIA and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Oct 25, 2023
cetincakiroglu added a commit that referenced this issue Oct 25, 2023
@cetincakiroglu
Merge pull request #13923 from GiacomoDM/bugfix/13902
21c5fa8 
Bugfix #13902 Fix TabView inkbar accessibility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
16.6.0
Development

Successfully merging a pull request may close this issue.

Bugfix #13902 Fix TabView inkbar accessibility GiacomoDM/primeng
2 participants
@GiacomoDM @cetincakiroglu