Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SelectButton in v16.7.1 is only partially fixed #14048

Closed
rosenthalj opened this issue Nov 7, 2023 · 0 comments · Fixed by #14049
Closed

SelectButton in v16.7.1 is only partially fixed #14048

rosenthalj opened this issue Nov 7, 2023 · 0 comments · Fixed by #14049
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@rosenthalj
Copy link
Contributor

Describe the bug

Issue #14021 (SelectButton broken in v16.7.0) for v16.7.1 was only partially fixed.

In v16.7.1 the option value is now correctly updated, but the property allowEmpty is still ignored.

I have updated the original reproducer to use PrimeNG v1.16.7.1 (no other changes) to demonstrate this issue.

The video listed below shows that the allowEmpty property is ignored (it also shows that the optitionValue is being set correctly)

SelectButtonAllowEmpty.mov

Environment

mac os and windows

Reproducer

https://stackblitz.com/edit/uqd2gx-4ug53g

Angular version

16.x

PrimeNG version

16.7.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.18.1

Browser(s)

safari, chrome, firefox

Steps to reproduce the behavior

  1. Run the reproducer: https://stackblitz.com/edit/uqd2gx-4ug53g
  2. Click the "Off" button on the top SelectButton
  3. The "Off" button color will change from blue to white and "select button: value = false" label will change to "select button: value = null"

Expected behavior

No change. The "Off" button color should remain blue and "select button: value = false" should also not change

@rosenthalj rosenthalj added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 7, 2023
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 8, 2023
@cetincakiroglu cetincakiroglu added this to the 16.8.0 milestone Nov 8, 2023
cetincakiroglu added a commit that referenced this issue Nov 8, 2023
Enforce allowEmpty for SelectButton, fixes issue #14048
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants