Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inputnumber: Inputnumber#currency mode not allowing to remove minus sign for Dollar and INR fields. #14327

Closed
akshayantony55 opened this issue Dec 11, 2023 · 0 comments · Fixed by #14328
Closed

Inputnumber: Inputnumber#currency mode not allowing to remove minus sign for Dollar and INR fields. #14327

akshayantony55 opened this issue Dec 11, 2023 · 0 comments · Fixed by #14328
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
17.2.0

Comments

@akshayantony55
Copy link
Contributor

Describe the bug

Inputnumber: Inputnumber#currency mode not allowing to remove minus sign for Dollar and INR fields.

Environment

https://primeng.org/inputnumber#currency

Using windows environment.

Reproducer

No response

Angular version

17.0

PrimeNG version

17.0.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.10

Browser(s)

No response

Steps to reproduce the behavior

  1. Go to https://primeng.org/inputnumber#currency.
  2. Remove existing currencies, and add minus sign to all the currencies with some currency values.
  3. Try to remove the minus sign by putting the cursor at the beginning position.
  4. Minus sign is successfully removed for Germany and Japan, but not removed for US and India.

Expected behavior

Minus sign should get removed for US and India currencies.
@akshayantony55 akshayantony55 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 11, 2023
akshayantony55 added a commit to qburst/primeng_qb_1 that referenced this issue Dec 11, 2023
@akshayantony55
fix: primefaces#14327, Inputnumber: Inputnumber#currency mode not all…
1a84546 
…owing to remove minus sign for Dollar and INR fields.
@akshayaqburst akshayaqburst mentioned this issue Dec 11, 2023
Merged
@cetincakiroglu cetincakiroglu added this to the 17.2.0 milestone Dec 20, 2023
cetincakiroglu added a commit that referenced this issue Dec 20, 2023
@cetincakiroglu
Merge pull request #14328 from qburst/master
7f32209 
fix: #14327, Inputnumber: Inputnumber#currency mode not allowing to remove minus sign for Dollar and INR fields.
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
17.2.0
2 participants
@akshayantony55 @cetincakiroglu