Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panel: id increments within component #14508

Closed
jasonverber opened this issue Jan 8, 2024 · 0 comments · Fixed by #14509
Closed

Panel: id increments within component #14508

jasonverber opened this issue Jan 8, 2024 · 0 comments · Fixed by #14509
Labels
LTS-16-PORTABLE Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
17.3.2

Comments

@jasonverber
Copy link
Contributor

Describe the bug

When using the panel component, a new unique id is used for the header, toggle button, content, etc.

Each time the id getter is called it generates a new value. The component should simply set the value once and use that.

Environment

Angular 17.0.8

Reproducer

https://stackblitz.com/edit/github-mfvt7h?file=src%2Fapp%2Fapp.component.html

Angular version

17.0.8

PrimeNG version

17.3.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.19.0

Browser(s)

No response

Steps to reproduce the behavior

  1. Use <p-panel>
  2. Inspect
  3. Compare the id values used for headers, aria-controls, etc.

Expected behavior

The Panel component should have one consistent id that is used throughout.
@jasonverber jasonverber added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 8, 2024
jasonverber added a commit to jasonverber/primeng that referenced this issue Jan 8, 2024
@jasonverber
primefaces#14508 Panel id generation
db40fe6
@jasonverber jasonverber mentioned this issue Jan 8, 2024
Merged
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 10, 2024
cetincakiroglu added a commit that referenced this issue Jan 10, 2024
@cetincakiroglu
Merge pull request #14509 from jasonverber/fix/14508-panel-id
8c9f3d0 
Fix #14508 Panel id generation
@cetincakiroglu cetincakiroglu added this to the 17.3.2 milestone Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
LTS-16-PORTABLE Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
17.3.2
Development

Successfully merging a pull request may close this issue.

Fix #14508 Panel id generation jasonverber/primeng
2 participants
@jasonverber @cetincakiroglu