Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component: Chips. Duplicate validation is case sensitive #14550

Closed
AndrewAKovalenko opened this issue Jan 15, 2024 · 2 comments · Fixed by #14551
Closed

Component: Chips. Duplicate validation is case sensitive #14550

AndrewAKovalenko opened this issue Jan 15, 2024 · 2 comments · Fixed by #14551
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
17.3.3

Comments

@AndrewAKovalenko
Copy link
Contributor

Describe the bug

Currently, chip validation in p-chips component is case sensitive, it means that test@test.com and Test@test.com (or test and Test) are considered different values and don't treated as duplication.

Environment

Chrome

Reproducer

No response

Angular version

17.0.2

PrimeNG version

17.3.2

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.10.0

Browser(s)

No response

Steps to reproduce the behavior

  1. Go to Chips
  2. Set [allowDuplicate]=false
  3. Type test and hit Enter
  4. Type Test and hit Enter
  5. Observe result

Expected behavior

Component should only have test value.
Test should be filtered out
@AndrewAKovalenko AndrewAKovalenko added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 15, 2024
@AndrewAKovalenko AndrewAKovalenko mentioned this issue Jan 15, 2024
Merged
@AndrewAKovalenko
Copy link
Contributor Author

Created pull requets to fix this issue #14551

@mertsincan
Copy link
Member

Thanks a lot for the PR! Please see my comment.

@mertsincan mertsincan added this to the 17.3.3 milestone Jan 15, 2024
@mertsincan mertsincan added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 15, 2024
mertsincan pushed a commit that referenced this issue Jan 17, 2024
@AndrewAKovalenko
Fix #14550: Chips. Fixed case sensitive chips validation (#14551)
e4cfa1b 
* fixed case sensitive chips validation

* added new input property caseSensitiveDuplication for chips component

---------

Co-authored-by: AKOVALENKO-NB\andrii.kovalenko <andrii.kovalenko@idealscorp.com>
@mertsincan mertsincan removed the Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. label Jan 17, 2024
@AndrewAKovalenko AndrewAKovalenko mentioned this issue Jan 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
17.3.3
Development

Successfully merging a pull request may close this issue.

Fix #14550: Chips. Fixed case sensitive chips validation AndrewAKovalenko/primeng
2 participants
@mertsincan @AndrewAKovalenko