Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p-columnFilter: Missing icons to the table column filter dialog #14613

Closed
rosenthalj opened this issue Jan 23, 2024 · 0 comments · Fixed by #14614
Closed

p-columnFilter: Missing icons to the table column filter dialog #14613

rosenthalj opened this issue Jan 23, 2024 · 0 comments · Fixed by #14614
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@rosenthalj
Copy link
Contributor

Describe the bug

The PrimeNG table's column filter dialog is missing the "trash" and "plus" icons.

The icons were in PrimeNG v14 (and earlier) but were "lost"

The first and second annotated screenshots are of the PrimeNG v17 table filter menu demo (https://primeng.org/table#filter-menu) showing the table's column filter dialog missing "plus" and "trash" icons.

Angular_Table_Component

Angular_Table_Component

The third and forth annotated screenshots are of the PrimeNG v14-lts table filter menu demo (https://www.primefaces.org/primeng-v14-lts/table#filter-menu) showing the table's column filter dialog with the "plus" and "trash" icons.

PrimeNG

PrimeNG

Examining the table.ts code, the TrashIcon and PlusIcons are actually included with the column filter dialog:

primeng_src_app_components_table_table_ts_at_master_·_primefaces_primeng

Environment

windows and macos

Reproducer

https://primeng.org/table#filter-menu

Angular version

17.x

PrimeNG version

17.3.3

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.18.1

Browser(s)

safari, chrome, firefox

Steps to reproduce the behavior

  1. Run the PrimeNG v17 table filter demo: https://primeng.org/table#filter-menu
  2. Click on the name column filter button
    -- The column filter dialog will be displayed (good)
    -- The "Add Rule" button of the column filter dialog will not have a "+" icon (bad)
  3. Click on the "Add Rule" button
    -- The column filter dialog will display two "Remove Rule" buttons (good)
    -- The "Remove Rule" buttons will not have "trash" icons (bad)

Expected behavior

The "+" and "trash" icons should be displayed with the coresponding buttons

@rosenthalj rosenthalj added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 23, 2024
@rosenthalj rosenthalj changed the title p-columnFilter: Add missing icons to the table column filter dialog p-columnFilter: Missing icons to the table column filter dialog Jan 23, 2024
cetincakiroglu added a commit that referenced this issue Jan 24, 2024
fix #14613 - updated column filter's trash and plus icons
@cetincakiroglu cetincakiroglu added this to the 17.4.0 milestone Jan 24, 2024
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants