Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component: InputNumber does not validate max on blur #14630

Closed
thatsmeta opened this issue Jan 25, 2024 · 0 comments · Fixed by #14632
Closed

Component: InputNumber does not validate max on blur #14630

thatsmeta opened this issue Jan 25, 2024 · 0 comments · Fixed by #14632
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
17.5.0

Comments

@thatsmeta
Copy link

Describe the bug

InputNumber used to validate the input against the max value before triggering the blur event.
E.g. max value is 5, the user types in 10, InputNumber used to / should trigger its blur EventEmitter only after having validated the user input against the max value.

Somehow, the blur emit got moved upwards a couples of lines in this commit:
5452e19#diff-d15eb5f971fcc845ef140641bb6498419d87b06832dd22180381101c84f55a70R1366

OnBlur should emit after validateValue() and updateModel() so that blur listeners get the correct number value from the input field.

Environment

see versions below

Reproducer

No response

Angular version

16.2.0

PrimeNG version

16.9.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@thatsmeta thatsmeta added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 25, 2024
thatsmeta pushed a commit to thatsmeta/primeng that referenced this issue Jan 25, 2024
fix(primefaces#14630): emit blur after input value validation
d273bfe
@thatsmeta thatsmeta mentioned this issue Jan 25, 2024
Merged
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Feb 1, 2024
@cetincakiroglu cetincakiroglu added this to the 17.5.0 milestone Feb 1, 2024
cetincakiroglu added a commit that referenced this issue Feb 1, 2024
@cetincakiroglu
Merge pull request #14632 from thatsmeta/issue-14630
f689f1e 
fix(#14630): emit blur after input value validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
17.5.0
Development

Successfully merging a pull request may close this issue.

fix(#14630): emit blur after input value validation thatsmeta/primeng
2 participants
@thatsmeta @cetincakiroglu