Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProgressSpinner: Unable to set aria-label #14798

Closed
akashuwtw opened this issue Feb 13, 2024 · 0 comments · Fixed by #14800
Closed

ProgressSpinner: Unable to set aria-label #14798

akashuwtw opened this issue Feb 13, 2024 · 0 comments · Fixed by #14800
Assignees
@mehmetcetin01140
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
17.7.0

Comments

@akashuwtw
Copy link

akashuwtw commented Feb 13, 2024 •
edited
Loading

Describe the bug

We are trying to set aria-label for p-progressSpinner but it is not getting applied as per the steps mentioned here.

Environment

OS: Windows 10

Reproducer

No response

Angular version

16.2.7

PrimeNG version

16.5.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.16.0

Browser(s)

Chrome 121.0.6167.161, Edge 121.0.2277.112

Steps to reproduce the behavior

<p-progressSpinner aria-label="Loading"></p-progressSpinner>

Expected behavior

aria-label should be applied
@akashuwtw akashuwtw added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Feb 13, 2024
@mehmetcetin01140 mehmetcetin01140 added this to the 17.7.0 milestone Feb 14, 2024
@cetincakiroglu cetincakiroglu added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Feb 14, 2024
@mehmetcetin01140 mehmetcetin01140 self-assigned this Feb 14, 2024
@mehmetcetin01140 mehmetcetin01140 added Component: Accessibility Issue or pull request is related to WCAG or ARIA Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible and removed Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Feb 14, 2024
mehmetcetin01140 added a commit that referenced this issue Feb 14, 2024
@mehmetcetin01140
Fixed #14798 - ProgressSpinner | Unable to set aria-label
af37a67
@mehmetcetin01140 mehmetcetin01140 mentioned this issue Feb 14, 2024
Merged
cetincakiroglu added a commit that referenced this issue Feb 14, 2024
@cetincakiroglu
Merge pull request #14800 from primefaces/issue-14798
59e0269 
Fixed #14798 - ProgressSpinner | Unable to set aria-label
@cetincakiroglu cetincakiroglu added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mehmetcetin01140 mehmetcetin01140

Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
17.7.0
Development

Successfully merging a pull request may close this issue.

Fixed #14798 - ProgressSpinner | Unable to set aria-label primefaces/primeng
3 participants
@cetincakiroglu @mehmetcetin01140 @akashuwtw