Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown: Dropdown no longer closes when clicking the currently selected option #14811

Closed
Airdevelopments opened this issue Feb 15, 2024 · 0 comments · Fixed by #14812
Closed

Dropdown: Dropdown no longer closes when clicking the currently selected option #14811

Airdevelopments opened this issue Feb 15, 2024 · 0 comments · Fixed by #14812
Assignees
@mehmetcetin01140
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
17.8.0

Comments

@Airdevelopments
Copy link

Describe the bug

After the change detection fix of #14788, the dropdown is no longer closing when click the currently selected option:

bug

Back in v15 it would still close:

bug

Environment

see below

Reproducer

https://stackblitz.com/edit/github-fz8npg?file=src%2Fapp%2Fapp.component.ts

Angular version

17.1.0

PrimeNG version

17.7.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.16.0

Browser(s)

Chrome 120

Steps to reproduce the behavior

No response

Expected behavior

When clicking the already selected option in the dropdown, the dropdown should just be dismissed / closed.
@Airdevelopments Airdevelopments added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Feb 15, 2024
@mehmetcetin01140 mehmetcetin01140 self-assigned this Feb 15, 2024
@mehmetcetin01140 mehmetcetin01140 added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Feb 15, 2024
@mehmetcetin01140 mehmetcetin01140 added this to the 17.8.0 milestone Feb 15, 2024
mehmetcetin01140 added a commit that referenced this issue Feb 15, 2024
@mehmetcetin01140
Fixed #14811 - Dropdown | Dropdown no longer closes when clicking the…
8893a65 
… currently selected option
@mehmetcetin01140 mehmetcetin01140 mentioned this issue Feb 15, 2024
Merged
cetincakiroglu added a commit that referenced this issue Feb 22, 2024
@cetincakiroglu
Merge pull request #14812 from primefaces/issue-14811
fc8747b 
Fixed #14811 - Dropdown | Dropdown no longer closes when clicking the…
rosenthalj referenced this issue Feb 22, 2024
@cetincakiroglu
Fixed #14801 and Fixed #14815
24ea912
@Airdevelopments Airdevelopments mentioned this issue Feb 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mehmetcetin01140 mehmetcetin01140

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
17.8.0
Development

Successfully merging a pull request may close this issue.

Fixed #14811 - Dropdown | Dropdown no longer closes when clicking the… primefaces/primeng
2 participants
@Airdevelopments @mehmetcetin01140