Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi select dropdown multiSelectItem missing role='option'. #14958

Closed
vinodneppalli62 opened this issue Mar 7, 2024 · 1 comment · Fixed by #15153
Closed

Multi select dropdown multiSelectItem missing role='option'. #14958

vinodneppalli62 opened this issue Mar 7, 2024 · 1 comment · Fixed by #15153
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
17.13.0

Comments

@vinodneppalli62
Copy link

vinodneppalli62 commented Mar 7, 2024 •
edited

Describe the bug

  1. JAWS screen reader reading selected checkbox as not selected while navigating through multi select dropdown options.
  2. Select All checkbox is always reading checkbox checked whether is checked or not (I think instead of setting false value to checked attribute on 'checkbox input' removing that attribute when it is not checked works).

Environment

Using prime ng multiselect in the application currently we are upgrading. We are using 16.9.1 and It is happening in latest version as well.

Reproducer

No response

Angular version

^16.2.0

PrimeNG version

^16.9.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.9.0

Browser(s)

Chrome

Steps to reproduce the behavior

No response

Expected behavior

Should read checked one as Selected and not checked one as Not Selected.
@vinodneppalli62 vinodneppalli62 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 7, 2024
@mehmetcetin01140 mehmetcetin01140 added Component: Accessibility Issue or pull request is related to WCAG or ARIA and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Mar 18, 2024
TaneliTuomola pushed a commit to TaneliTuomola/primeng that referenced this issue Mar 25, 2024
fix primefaces#14958 MultiSelectItem role=option
3ee1b7a
@TaneliTuomola TaneliTuomola mentioned this issue Mar 25, 2024
Merged
@cetincakiroglu cetincakiroglu added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Mar 29, 2024
@cetincakiroglu cetincakiroglu added this to the 17.13.0 milestone Mar 29, 2024
cetincakiroglu added a commit that referenced this issue Mar 29, 2024
@cetincakiroglu
Merge pull request #15153 from TaneliTuomola/issue-14958
4f99df0 
fix #14958 MultiSelectItem role=option
@vinodneppalli62
Copy link
Author

vinodneppalli62 commented Mar 29, 2024 •
edited

role='option' fixed the options(multiSelecteItem) accessibility but select all check box near filter input is always reading checked even though it is not selected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
17.13.0
Development

Successfully merging a pull request may close this issue.

fix #14958 MultiSelectItem role=option TaneliTuomola/primeng
3 participants
@vinodneppalli62 @cetincakiroglu @mehmetcetin01140