Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar, TreeSelect, MultiSelect: Invalid aria-controls attribute value. Overlay missing an id attribute. #14980

Closed
TaneliTuomola opened this issue Mar 8, 2024 · 0 comments · Fixed by #15018
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA LTS-16-PORTABLE Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@TaneliTuomola
Copy link

TaneliTuomola commented Mar 8, 2024

          In addition to what was mentioned in this ticket, the Calendar's **panelId** does not refer to any element in the Calender.  I think the Calendar template needs to be updated so that the **div.p-datepicker** element should have an **id** attribute set to **panelId**:
...
            <div
                #contentWrapper
           [attr.id]="panelId"
                [class]="panelStyleClass"
                [ngStyle]="panelStyle"
                [ngClass]="{
                    'p-datepicker p-component': true,
                    'p-datepicker-inline': inline,
                    'p-disabled': disabled,
                    'p-datepicker-timeonly': timeOnly,
                    'p-datepicker-multiple-month': this.numberOfMonths > 1,
                    'p-datepicker-monthpicker': view === 'month',
                    'p-datepicker-touch-ui': touchUI
                }"
...

Originally posted by @barbGit2 in #14358 (comment)

Tested with primeNg 17.10.0: https://primeng.org/calendar

@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 8, 2024
@TaneliTuomola TaneliTuomola changed the title Calendar: Invalid aria-controls attribute value. Overlay missing an id attribute. Calendar, TreeSelect, MultiSelect: Invalid aria-controls attribute value. Overlay missing an id attribute. Mar 8, 2024
TaneliTuomola pushed a commit to TaneliTuomola/primeng that referenced this issue Mar 12, 2024
@cetincakiroglu cetincakiroglu added this to the 17.12.0 milestone Mar 14, 2024
@cetincakiroglu cetincakiroglu added LTS-16-PORTABLE Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add Component: Accessibility Issue or pull request is related to WCAG or ARIA and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Mar 19, 2024
cetincakiroglu added a commit that referenced this issue Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA LTS-16-PORTABLE Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants