Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

p-chip: Missing button role on a remove icon #15095

Closed
TaneliTuomola opened this issue Mar 20, 2024 · 0 comments · Fixed by #15096
Closed

p-chip: Missing button role on a remove icon #15095

TaneliTuomola opened this issue Mar 20, 2024 · 0 comments · Fixed by #15096
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
17.12.0

Comments

@TaneliTuomola
Copy link

Describe the bug

Remove icon elements are missing a button role and aria-label attribute cannot be used on a remove icon element (TimesCircleIcon & span) with no valid role attribute.

The button role identifies an element as a button to assistive technology such as screen readers.

Environment

chrome

Reproducer

https://primeng.org/chip

Angular version

17.0.0

PrimeNG version

17.11.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.16.0

Browser(s)

No response

Steps to reproduce the behavior

https://primeng.org/chip

Expected behavior

No response
@TaneliTuomola TaneliTuomola added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 20, 2024
TaneliTuomola pushed a commit to TaneliTuomola/primeng that referenced this issue Mar 20, 2024
fix primefaces#15095 Added button role
961eeaa
@TaneliTuomola TaneliTuomola mentioned this issue Mar 20, 2024
Merged
@cetincakiroglu cetincakiroglu added this to the 17.12.0 milestone Mar 20, 2024
@cetincakiroglu cetincakiroglu added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Mar 20, 2024
cetincakiroglu added a commit that referenced this issue Mar 20, 2024
@cetincakiroglu
Merge pull request #15096 from TaneliTuomola/issue-15095
9711d21 
fix #15095 Added button role
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
17.12.0
Development

Successfully merging a pull request may close this issue.

fix #15095 Added button role TaneliTuomola/primeng
2 participants
@cetincakiroglu @TaneliTuomola