Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Steps: Invalid and unnecessary tablist role structure #15099

Closed
TaneliTuomola opened this issue Mar 20, 2024 · 0 comments · Fixed by #15098
Closed

Steps: Invalid and unnecessary tablist role structure #15099

TaneliTuomola opened this issue Mar 20, 2024 · 0 comments · Fixed by #15098
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA LTS-16-PORTABLE Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@TaneliTuomola
Copy link

Describe the bug

Discussed in https://github.com/orgs/primefaces/discussions/1436

https://primeng.org/steps

Step container element (ul[role="tablist"]) has children which are not allowed: li[role=presentation]. The tablist role seems to have been included since the first version of the component, so it may not been considered from the accessibility perspective.

In the primeVue and primeReact <ol><li><a> structure without tablist role is used.

image

Environment

Chrome

Reproducer

https://primeng.org/steps/personal

Angular version

17.0.0

PrimeNG version

17.11.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.16.0

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response

@TaneliTuomola TaneliTuomola added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 20, 2024
@cetincakiroglu cetincakiroglu added this to the 17.12.0 milestone Mar 20, 2024
@cetincakiroglu cetincakiroglu added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add Component: Accessibility Issue or pull request is related to WCAG or ARIA LTS-16-PORTABLE and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA LTS-16-PORTABLE Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants