Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Steps: Update link element attributes #15133

Closed
TaneliTuomola opened this issue Mar 21, 2024 · 0 comments · Fixed by #15134
Closed

Steps: Update link element attributes #15133

TaneliTuomola opened this issue Mar 21, 2024 · 0 comments · Fixed by #15134
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
17.13.0

Comments

@TaneliTuomola
Copy link

Describe the bug

After removing tablist roles from the steps component (#15099) there is no need for aria-selected attribute and it may confuse screen readers. Its also good to add a role="link" so that element is always considered a link by screen readers.

Environment

chrome

Reproducer

https://primeng.org/steps/personal

Angular version

17.0.0

PrimeNG version

17.12.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.16.0

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@TaneliTuomola TaneliTuomola added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 21, 2024
TaneliTuomola pushed a commit to TaneliTuomola/primeng that referenced this issue Mar 21, 2024
fix primefaces#15133 Update steps link attributes
08b1f53
@TaneliTuomola TaneliTuomola mentioned this issue Mar 21, 2024
Merged
@cetincakiroglu cetincakiroglu added this to the 17.13.0 milestone Mar 22, 2024
@cetincakiroglu cetincakiroglu added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add Component: Accessibility Issue or pull request is related to WCAG or ARIA and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Mar 22, 2024
cetincakiroglu added a commit that referenced this issue Mar 22, 2024
@cetincakiroglu
Merge pull request #15134 from TaneliTuomola/issue-15133
5f32de3 
fix #15133 Update steps link attributes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
17.13.0
Development

Successfully merging a pull request may close this issue.

fix #15133 Update steps link attributes TaneliTuomola/primeng
2 participants
@cetincakiroglu @TaneliTuomola