Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component: p-dropdown #15112

Closed
WTW-Jacob-Evans opened this issue Mar 20, 2024 · 1 comment
Closed

Component: p-dropdown #15112

WTW-Jacob-Evans opened this issue Mar 20, 2024 · 1 comment
Assignees
@mehmetcetin01140
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA PRO Support Issue was reported by PRO User Status: Discussion Issue or pull request needs to be discussed by Core Team Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
17.13.0

Comments

@WTW-Jacob-Evans
Copy link

WTW-Jacob-Evans commented Mar 20, 2024 •
edited

Describe the bug

When the dropdown is expanded but there are no values, and the "no results found" message is shown, Axe DevTools is showing an accessibility issue. This is related to the list not being contained within the ul or ol tags that have the role "list" or no role (the current role is "listbox").
image
image

Environment

windows 10

Reproducer

https://stackblitz.com/github/primefaces/primeng-issue-template?file=src%2Fapp%2Fapp.component.ts,src%2Fapp%2Fapp.module.ts

Angular version

17.2.3

PrimeNG version

17.11.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.18.0

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@WTW-Jacob-Evans WTW-Jacob-Evans added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 20, 2024
@cetincakiroglu cetincakiroglu added Component: Accessibility Issue or pull request is related to WCAG or ARIA PRO Support Issue was reported by PRO User and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Mar 25, 2024
@cetincakiroglu cetincakiroglu added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Mar 25, 2024
@cetincakiroglu cetincakiroglu added this to the 17.13.0 milestone Mar 25, 2024
mlz11 added a commit to mlz11/primeng that referenced this issue Mar 25, 2024
@mlz11
Fixed primefaces#15112 - Give list role instead of listbox to items l…
2f731ec 
…ist when empty
@mlz11 mlz11 mentioned this issue Mar 25, 2024
Closed
mlz11 added a commit to mlz11/primeng that referenced this issue Mar 25, 2024
@mlz11
Fixes primefaces#15112 - Give list role instead of listbox to items l…
68d1f1d 
…ist when empty
@mlz11
Copy link

mlz11 commented Mar 25, 2024

Hey @cetincakiroglu @mehmetcetin01140 👋🏻

I have opened the following PR #15157 attempting to fix the issue. Don't hesitate to tell me what you think of it !

@cetincakiroglu cetincakiroglu added the Status: Discussion Issue or pull request needs to be discussed by Core Team label Mar 26, 2024
cetincakiroglu added a commit that referenced this issue Mar 29, 2024
@cetincakiroglu
Merge pull request #15196 from primefaces/issue-15112
d765b6b 
Fixed #15112
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mehmetcetin01140 mehmetcetin01140

Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA PRO Support Issue was reported by PRO User Status: Discussion Issue or pull request needs to be discussed by Core Team Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
17.13.0
Development

Successfully merging a pull request may close this issue.

Fixes #15112 - Give list role instead of listbox to items list when e… mlz11/primeng
4 participants
@cetincakiroglu @mehmetcetin01140 @mlz11 @WTW-Jacob-Evans