Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component: Table/Paginator - pageLinks/pageLinkSize do not affect number of page links after initialization #15231

Closed
BeloMaximka opened this issue Apr 8, 2024 · 0 comments · Fixed by #15232
Closed

Component: Table/Paginator - pageLinks/pageLinkSize do not affect number of page links after initialization #15231

BeloMaximka opened this issue Apr 8, 2024 · 0 comments · Fixed by #15232
Labels
good first issue *** Welcome to PrimeNG Family! *** Good issue! Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
17.13.0

Comments

@BeloMaximka
Copy link
Contributor

Describe the bug

Updating pageLinks Input in Table or pageLinkSize in Paginator after initialization does not update the number of page links

Environment

Angular 17

Reproducer

https://stackblitz.com/edit/github-uypjvh?file=src%2Fapp%2Fapp.component.html

Angular version

17.3.1

PrimeNG version

17.12.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.17.0

Browser(s)

Chrome / latest

Steps to reproduce the behavior

  1. Create a class field links = 5
  2. Create a p-table with [paginator]="true" [rows]="5" [totalRecords]="1500" [pageLinks]="links"
  3. Change the value of links to a different number after initialization.

Expected behavior

The number of visible page links changes after changing the value of links
@BeloMaximka BeloMaximka added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 8, 2024
@BeloMaximka BeloMaximka mentioned this issue Apr 8, 2024
Merged
@cetincakiroglu cetincakiroglu added this to the 17.13.0 milestone Apr 9, 2024
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Apr 9, 2024
cetincakiroglu added a commit that referenced this issue Apr 9, 2024
@cetincakiroglu
Merge pull request #15232 from BeloMaximka/master
0b94f44 
Fixed #15231: update page links when pageLinkSize is changed
@cetincakiroglu cetincakiroglu added the good first issue *** Welcome to PrimeNG Family! *** Good issue! label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue *** Welcome to PrimeNG Family! *** Good issue! Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
17.13.0
Development

Successfully merging a pull request may close this issue.

Fixed #15231: update page links when pageLinkSize is changed BeloMaximka/primeng
2 participants
@BeloMaximka @cetincakiroglu