Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p-editor only shows unstyled buttons when it's inside of p-sidebar #15297

Closed
rubenteck opened this issue Apr 18, 2024 · 4 comments · Fixed by #15372
Closed

p-editor only shows unstyled buttons when it's inside of p-sidebar #15297

rubenteck opened this issue Apr 18, 2024 · 4 comments · Fixed by #15372
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@rubenteck
Copy link

Describe the bug

When placing a p-editor inside a p-sidebar, it doesn't properly render the p-editor. Only the header's buttons are showed without styling.
stackblitz: https://stackblitz.com/edit/github-evzyaq?file=src%2Fapp%2Fapp.component.ts

Environment

I use a windows 11 laptop with IntelliJ. Angular 17.3.4, PrimeNG 17.13.0 and node v18.20.1.

Reproducer

https://stackblitz.com/edit/github-evzyaq?file=src%2Fapp%2Fapp.component.ts

Angular version

17.3.4

PrimeNG version

17.13.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

v18.20.1

Browser(s)

No response

Steps to reproduce the behavior

  1. place a p-editor inside a p-sidebar
  2. open the sidebar

Expected behavior

the p-editor should render correctly and be useable

@rubenteck rubenteck added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 18, 2024
@RinoGaetano94
Copy link

RinoGaetano94 commented Apr 18, 2024

Same here passing it to a custom component. Something like:

my-custom-container.component.html

<div>
  <ng-content />
</div>

foobar.component.html

<my-custom-container>
  <p-editor />
</my-custom-container>

Angular 17.3.4
PrimeNG 17.13.0
Quill 2.0.0
Node 20.9.0

@dl3g0
Copy link

dl3g0 commented Apr 19, 2024

Same here passing

@cetincakiroglu cetincakiroglu added this to the 17.15.0 milestone Apr 19, 2024
@aaron-cardenas
Copy link

Its the same in dialogs, it seams related to fix of SSR in 17.13.0.

@rubenteck
Copy link
Author

I can confirm that this was not an issue in PrimeNG 17.12.0 and earlier.
Stackblitz with PrimeNG 17.12.0
(please note that I have also imported quill styles here in the angular.json file)

cetincakiroglu added a commit that referenced this issue Apr 26, 2024
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Apr 26, 2024
nbrown-ScottLogic pushed a commit to nbrown-ScottLogic/primeng that referenced this issue May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants