Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Badge | Deprecate "size" property #15314

Closed
cetincakiroglu opened this issue Apr 19, 2024 · 0 comments · Fixed by #15315
Closed

Badge | Deprecate "size" property #15314

cetincakiroglu opened this issue Apr 19, 2024 · 0 comments · Fixed by #15315
Assignees
@cetincakiroglu
Labels
Type: Breaking Change Issue contains a breaking change related to a specific component Type: Deprecated Issue contains a deprecated component. The component will be removed in any future release
Milestone
17.14.0

Comments

@cetincakiroglu
Copy link
Contributor

size input property will be deprecated due to name collision when used with avatar component.
Similar issue: #12959

badgeSize input property will be added as replacement.

size property will be removed in PrimeNG v18
@cetincakiroglu cetincakiroglu added the Type: Deprecated Issue contains a deprecated component. The component will be removed in any future release label Apr 19, 2024
@cetincakiroglu cetincakiroglu added this to the 17.14.0 milestone Apr 19, 2024
@cetincakiroglu cetincakiroglu self-assigned this Apr 19, 2024
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 19, 2024
cetincakiroglu added a commit that referenced this issue Apr 19, 2024
@cetincakiroglu
Fixed #15314 - Deprecate size property
8fd44bd
@cetincakiroglu cetincakiroglu mentioned this issue Apr 19, 2024
Merged
cetincakiroglu added a commit that referenced this issue Apr 19, 2024
@cetincakiroglu
Merge pull request #15315 from primefaces/issue-15314
3e67968 
Fixed #15314 - Deprecate size property
@cetincakiroglu cetincakiroglu added Type: Breaking Change Issue contains a breaking change related to a specific component and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cetincakiroglu cetincakiroglu

Labels
Type: Breaking Change Issue contains a breaking change related to a specific component Type: Deprecated Issue contains a deprecated component. The component will be removed in any future release
Projects
None yet
Milestone
17.14.0
Development

Successfully merging a pull request may close this issue.

Fixed #15314 - Deprecate size property primefaces/primeng
1 participant
@cetincakiroglu