Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown: Invalid abstract role 'section' in p-dropdown-items-wrapper #15339

Closed
TaneliTuomola opened this issue Apr 23, 2024 · 0 comments · Fixed by #15461
Closed

Dropdown: Invalid abstract role 'section' in p-dropdown-items-wrapper #15339

TaneliTuomola opened this issue Apr 23, 2024 · 0 comments · Fixed by #15461
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
17.16.1

Comments

@TaneliTuomola
Copy link

TaneliTuomola commented Apr 23, 2024 •
edited

Describe the bug

Abstract roles are only intended for use by browsers to help organize and streamline a document. They should not be used by developers writing HTML markup. Doing so will not result in any meaningful information being conveyed to assistive technologies or to users. https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles#6._abstract_roles
image

The section role was added in this commit:
4335800 @cetincakiroglu

Environment

Chrome
https://primeng.org/dropdown

Reproducer

https://primeng.org/dropdown

Angular version

17.0.0

PrimeNG version

17.14.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.16.0

Browser(s)

No response

Steps to reproduce the behavior

https://primeng.org/dropdown
Open dropdown overlay

Expected behavior

No response
@TaneliTuomola TaneliTuomola added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 23, 2024
TaneliTuomola pushed a commit to TaneliTuomola/primeng that referenced this issue May 6, 2024
fix primefaces#15339 Removed invalid abstract role section
ccbabe5
@TaneliTuomola TaneliTuomola mentioned this issue May 6, 2024
Merged
@cetincakiroglu cetincakiroglu added this to the 17.16.1 milestone May 8, 2024
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working Component: Accessibility Issue or pull request is related to WCAG or ARIA and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels May 8, 2024
cetincakiroglu added a commit that referenced this issue May 8, 2024
@cetincakiroglu
Merge pull request #15461 from TaneliTuomola/issue-15339
b791159 
fix #15339 Remove invalid abstract role section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
17.16.1
Development

Successfully merging a pull request may close this issue.

fix #15339 Remove invalid abstract role section TaneliTuomola/primeng
2 participants
@cetincakiroglu @TaneliTuomola