Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog | tabbing order is broken because of pFocusTrap #15482

Closed
cetincakiroglu opened this issue May 7, 2024 · 0 comments · Fixed by #15519
Closed

Dialog | tabbing order is broken because of pFocusTrap #15482

cetincakiroglu opened this issue May 7, 2024 · 0 comments · Fixed by #15519
Assignees
@cetincakiroglu
Labels
LTS-FIXED-16.9.9 Fixed in PrimeNG LTS 16.9.9 LTS-PORTABLE PRO Support Issue was reported by PRO User Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
17.17.0

Comments

@cetincakiroglu
Copy link
Contributor

Behavior: Cannot focus on the last button in demo.
Expected: It should follow the tabbing order.

https://stackblitz.com/edit/z65yqt?file=src%2Fapp%2Fdemo%2Flistbox-basic-demo.html
@cetincakiroglu cetincakiroglu added the PRO Support Issue was reported by PRO User label May 7, 2024
@cetincakiroglu cetincakiroglu added this to the 17.16.1 milestone May 7, 2024
@cetincakiroglu cetincakiroglu self-assigned this May 7, 2024
@cetincakiroglu cetincakiroglu added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label May 7, 2024
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 7, 2024
@cetincakiroglu cetincakiroglu modified the milestones: 17.16.1, 17.16.2 May 9, 2024
cetincakiroglu added a commit that referenced this issue May 10, 2024
@cetincakiroglu
Fixed #15482 - Rework and update focustrap
d10cb09
@cetincakiroglu cetincakiroglu mentioned this issue May 10, 2024
Merged
@cetincakiroglu cetincakiroglu removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 10, 2024
@mehmetcetin01140 mehmetcetin01140 added the LTS-FIXED-16.9.9 Fixed in PrimeNG LTS 16.9.9 label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cetincakiroglu cetincakiroglu

Labels
LTS-FIXED-16.9.9 Fixed in PrimeNG LTS 16.9.9 LTS-PORTABLE PRO Support Issue was reported by PRO User Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
17.17.0
Development

Successfully merging a pull request may close this issue.

Issue 15482 - Rework and update focustrap primefaces/primeng
2 participants
@cetincakiroglu @mehmetcetin01140