Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P-Splitter: Does not respect minSizes array after upgrading to 17.16.1 #15637

Closed
JCarusWTW opened this issue May 21, 2024 · 4 comments · Fixed by #15802
Closed

P-Splitter: Does not respect minSizes array after upgrading to 17.16.1 #15637

JCarusWTW opened this issue May 21, 2024 · 4 comments · Fixed by #15802
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@JCarusWTW
Copy link

Describe the bug

We have a p-splitter in our code, with a minSizes array of [25,25] being passed in. We have recently upgraded the primeng version from 16.9.1 to 17.16.1 and the minSizes array is no longer being respected i.e. whereas you used to be unable to drag the p-splitter handle past the minimum of 25% size for either panel, the user is now allowed full resizing between 0 and 100% of the possible size despite the 25% minimums still being in the code. You can reproduce the issue purely by switching between versions (no code changes).

Environment

Windows, typescript, version 17.16.1 for primeng

Reproducer

https://github-7cfjki.stackblitz.io

Angular version

17.3.8

PrimeNG version

17.16.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.11.0 and/or 21.6.1

Browser(s)

No response

Steps to reproduce the behavior

  1. Use splitter on stackblitz and note the fact that you can drag the handle anywhere within the two panels
  2. Go to package.json, change line 9 (version of primeng) to 16.9.1, ensure it rebuilds
  3. Use the splitter and note that you cannot resize either panel smaller than 25% (as set in minSizes array in html file)

Expected behavior

I expect the behaviour from v17 to match that of v16 (and the docs) i.e. if minSizes is set to 25,25 then the user should be unable to resize either panel to smaller than 25%.

@JCarusWTW JCarusWTW added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 21, 2024
@PranKe01
Copy link

I can confirm this bug. It also does not work in primeng components demo page.

@raiworld81
Copy link

+1

@heiooyooy
Copy link

heiooyooy commented May 30, 2024

+1
The pull request #14646, commit no: b3e91c7 created this issue.
"add input transform numberAttribute" to minSizes of splitter, which is a number[], not a number, was apparently a mistake.
please fix this issue thanks.

@PranKe01
Copy link

PranKe01 commented Jun 4, 2024

@cetincakiroglu Probably a duplicate of issue #15629. Looks like a low hanging fruit, which should be easy to fix. Would be nice if it would get fixed with next version (:

@cetincakiroglu cetincakiroglu modified the milestones: 18.0.0-rc.1, 17.18.1 Jun 4, 2024
@mehmetcetin01140 mehmetcetin01140 added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jun 6, 2024
@mehmetcetin01140 mehmetcetin01140 self-assigned this Jun 6, 2024
cetincakiroglu added a commit that referenced this issue Jun 13, 2024
Fixed #15637 - P-Splitter: Does not respect minSizes array after upgr…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants