Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pTree: right click on treenode chevron down #15714

Closed
matusko89 opened this issue May 27, 2024 · 0 comments · Fixed by #15821
Closed

pTree: right click on treenode chevron down #15714

matusko89 opened this issue May 27, 2024 · 0 comments · Fixed by #15821
Assignees
Labels
LTS-16-PORTABLE LTS-FIXED-15.4.21 LTS-FIXED-16.9.11 Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@matusko89
Copy link

Describe the bug

If you right click on the treenode icon you get an error

TypeError: eventTarget.className.indexOf is not a function
    at Tree.onNodeRightClick (primeng-tree.mjs:1241:64)
    at UITreeNode.onNodeRightClick (primeng-tree.mjs:100:19)
    at UITreeNode_ng_template_0_li_1_Template_div_contextmenu_1_listener (primeng-tree.mjs:473:36)
    at executeListenerWithErrorHandling (core.mjs:25638:16)
    at wrapListenerIn_markDirtyAndPreventDefault (core.mjs:25672:22)
    at HTMLDivElement.<anonymous> (platform-browser.mjs:679:17)
    at _ZoneDelegate.invokeTask (zone.js:402:31)
    at core.mjs:14556:55
    at AsyncStackTaggingZoneSpec.onInvokeTask (core.mjs:14556:36)
    at _ZoneDelegate.invokeTask (zone.js:401:60)

it seems as the icon is now an svg the className property does not have a indexOf function as it is not a string but a SVGAnimatedString

Environment

Any enviroment

Reproducer

No response

Angular version

17.3.10

PrimeNG version

17.17.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.10.0

Browser(s)

Chrome 125

Steps to reproduce the behavior

Have a tree with expandable node, try to right click on the expand icon

Expected behavior

No response

@matusko89 matusko89 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 27, 2024
@mehmetcetin01140 mehmetcetin01140 added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jun 11, 2024
@mehmetcetin01140 mehmetcetin01140 self-assigned this Jun 11, 2024
@mehmetcetin01140 mehmetcetin01140 added this to the 17.18.1 milestone Jun 11, 2024
cetincakiroglu added a commit that referenced this issue Jun 13, 2024
Fixed #15714 - pTree: right click on treenode chevron down
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LTS-16-PORTABLE LTS-FIXED-15.4.21 LTS-FIXED-16.9.11 Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants