Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance improvements on TreeTable #6898

Closed
qad84 opened this issue Nov 21, 2018 · 2 comments
Closed

Performance improvements on TreeTable #6898

qad84 opened this issue Nov 21, 2018 · 2 comments
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@qad84
Copy link

qad84 commented Nov 21, 2018

Hi,

The DOM event take very long time when expand/collapse node.

[ ] bug report => Search github for a similar issue or PR before submitting
[x ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

sample stackblitz
https://angular-primeng-treeview-demo-p5yahy.stackblitz.io


**Current behavior**
This is sample demo: 
https://angular-primeng-treeview-demo-p5yahy.stackblitz.io 
When expand node, there is DOM event (click) takes a long time (in IE/Edge) 
This event will execute many removeChild() and insertBefore() functions. 
In case we have a lot of nodes then it will take minutes just for expand/ collapse node

I also use lazy load for child nodes 

**Expected behavior**
Improve the performance of DOM event on expand/collapse event.

**What is the motivation / use case for changing the behavior?**
<!-- Describe the motivation or the concrete use case -->

**Please tell us about your environment:**
<!-- Operating system, IDE, package manager, HTTP server, ... -->

* **Angular version:** 
6.1.x

* **PrimeNG version:** ^6.1.2

* **Browser:** IE & Edge
 
* **Node (for AoT issues):** `node --version` =   v8.11.3
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Dec 31, 2018
@cagataycivici cagataycivici added this to the 7.0.4 milestone Dec 31, 2018
cagataycivici added a commit that referenced this issue Dec 31, 2018
fixed #6898 Treeview clickevent take long time on IE
@cagataycivici cagataycivici changed the title Treeview clickevent take long time on IE Performance improvements on TreeTable Dec 31, 2018
@cagataycivici cagataycivici added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Type: Bug Issue contains a bug related to a specific component. Something about the component is not working labels Dec 31, 2018
@qad84
Copy link
Author

qad84 commented Jan 10, 2019

Hello @cagataycivici,

Could you please check it again?
This issue still happen in my example:
https://angular-primeng-treeview-demo-akjnct.stackblitz.io

It is still take 1-2s to expand/collapse in IE and Edge.

Many thanks

@keval101
Copy link

@cagataycivici,

I Have checked it with only 200rows but it takes 1-2s for expand/collapse.

browser: Chrome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

4 participants