Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style and styleClass for ConfirmDialog #7017

Closed
skormel opened this issue Dec 18, 2018 · 1 comment
Closed

style and styleClass for ConfirmDialog #7017

skormel opened this issue Dec 18, 2018 · 1 comment
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@skormel
Copy link

skormel commented Dec 18, 2018

I'm submitting a ... (check one with "x")

[X] bug report => Search github for a similar issue or PR before submitting

Current behavior
I've just upgraded to primeNG 7.0.3, and notice that some inputs of Dialog and confirmDialog are deprecated (width, height, minWidth, minHeight) by style input. This works correctly with Dialog but not with confirmdialog. I can't set its width without width input (but this it's deprecated).

I notice that confirmDialog Component doesn't have style or ngStyle input, but dialog yes.

Test case
https://github-w4h5cc.stackblitz.io

Expected behavior
Set width with new style input.

gasparbarancelli pushed a commit to gasparbarancelli/primeng that referenced this issue Dec 19, 2018
Add property style and styleClass in component Confirm Dialog
@yigitfindikli yigitfindikli added this to the 7.0.4 milestone Dec 20, 2018
@yigitfindikli yigitfindikli added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Dec 20, 2018
@cagataycivici cagataycivici changed the title ConfirmDialog set width style and styleClass for ConfirmDialog Dec 31, 2018
cagataycivici added a commit that referenced this issue Dec 31, 2018
@danteorlando-acgov
Copy link

It looks like the docs were updated incorrectly on this. The style and styleClass properties were added to the section that describes the properties that are on the Confirmation instance that is passed to the confirm method on ConfirmationService. They should be added to the section below that describes the properties for p-confirmDialog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants