Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with server side rendering in these three components (button, inputmask, & keyfilter) #9036

Closed
captain01010101 opened this issue Jul 14, 2020 · 5 comments
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add

Comments

@captain01010101
Copy link

If you have a PrimeNG PRO Support subscription please post your issue at;

https://pro.primefaces.org

where our team will respond within 4 business hours.

If you do not have a PrimeNG PRO Support subscription, fill-in the report below. Please note that
your issue will be added to the waiting list of community issues and will be reviewed on a first-come first-serve basis, as a result, the support team is unable to guarantee a specific schedule on when it will be reviewed. Thank you for your understanding.

Current Queue Time for Review
Without PRO Support: ~8-12 weeks.
With PRO Support: 1 hour

I'm submitting a ... (check one with "x")

[x ] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Current behavior
Build fails with navigator and document error

Expected behavior
Should be able to SSR and prerender

Minimal reproduction of the problem with instructions
latest version of angular & universal. run command npm run prerender with these components in your app and build will fail

What is the motivation / use case for changing the behavior?

Please tell us about your environment:

  • Angular version: 5.X
    9x

  • PrimeNG version: 5.X
    9x

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

  • Language: [all | TypeScript X.X | ES6/7 | ES5]
    all

  • Node (for AoT issues): node --version =

@cagataycivici cagataycivici self-assigned this Sep 1, 2020
@cagataycivici cagataycivici added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Sep 1, 2020
@cagataycivici cagataycivici modified the milestones: 10.FUTURE, 10.0.1 Sep 1, 2020
@cagataycivici cagataycivici modified the milestones: 10.0.1, 10.FUTURE Sep 30, 2020
@cagataycivici cagataycivici removed this from the 11.FUTURE milestone Nov 17, 2020
@GerkinDev
Copy link

GerkinDev commented Mar 10, 2021

Same for Ripple (according to my own experience right now) and Carousel (according to #8447) directives. And probably many others.

So sad, I thought about buying a licence, but I won't because for now I have to rewrite almost everything for SSR to work.

Related to #8447, #8817 and probably many others.

Hey guys, you're missing some sells here.

@captain01010101
Copy link
Author

Same for Ripple (according to my own experience right now) and Carousel (according to #8447) directives. And probably many others.

So sad, I thought about buying a licence, but I won't because for now I have to rewrite almost everything for SSR to work.

Related to #8447, #8817 and probably many others.

Hey guys, you're missing some sells here.

What version are you working on? Not sure about the ones you mentioned but the ones I found were easily fixed.

@GerkinDev
Copy link

I used the latest one available on NPM.

PaveLiArcH added a commit to PaveLiArcH/primeng that referenced this issue Apr 25, 2021
@mertsincan
Copy link
Member

Hi,

So sorry for the delayed response! Improvements have been made to many components recently, both in terms of performance and enhancement. Therefore, this improvement may have been developed in another issue ticket without realizing it. You can check this in the documentation. If there is no improvement on this, can you reopen the issue so we can include it in our roadmap?
Please don't forget to add your feedback as a comment after reopening the issue. These will be taken into account by us and will contribute to the development of this feature. Thanks a lot for your understanding!

Best Regards,

@camilo-mujica
Copy link

Same here with table and carousel components :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

5 participants