Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TreeTable onEditComplete not triggered #9307

Closed
zhq3k opened this issue Sep 23, 2020 · 10 comments
Closed

TreeTable onEditComplete not triggered #9307

zhq3k opened this issue Sep 23, 2020 · 10 comments
Assignees
Labels
LTS-FIXED-9.2.8 Fixed in PrimeNG LTS 9.2.8 LTS-FIXED-10.1.2 Fixed in PrimeNG LTS 10.1.2 Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@zhq3k
Copy link

zhq3k commented Sep 23, 2020

[x ] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35


Using TreeTable and edit the binding data, when input the value on one cell and using mouse click to another cell, onEditComplete event not triggered.

**Current behavior**
onEditComplete event not triggered.

**Expected behavior**
onEditComplete will be triggered when click to another cell




**Please tell us about your environment:**

Angular version: 10

PrimeNG version: 10.0.0

Browser: Chrome 85

Language: TypeScript 3.9
@faheemworkspace
Copy link

any fix to this ??

@Krustie101
Copy link

Krustie101 commented Oct 29, 2020

Comparing the code between "treeTable" and "table" regarding editability, I see the code in "table" is a little bit more sophisticated in handling editability. I think some fixes/features still need to be ported from "table" to "treetable".

  • This particular problem seems to be situated in the bindDocumentListener
  • I see also differences regarding tabbing that probably allow to close an invalid cell that is being edited.

@yigitfindikli yigitfindikli added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Nov 25, 2020
@InfoCharlesM
Copy link

I think this is the same issue than #9113

I got the same issue, hope it will be fixed soon :D

@InfoCharlesM
Copy link

InfoCharlesM commented Feb 23, 2021

@yigitfindikli

Is the review still planned ?

I can't use prime-tree-tables because of this and the bug on p-calendars inside tables.

-> On this stackblitz you can see in the console that when you enter a cell "onEditInit" is fired, but when you click out, "onEditComplete" isn't fired

@yigitfindikli yigitfindikli self-assigned this Mar 11, 2021
@yigitfindikli yigitfindikli added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Mar 11, 2021
@yigitfindikli yigitfindikli added this to the 11.3.1 milestone Mar 11, 2021
@InfoCharlesM
Copy link

InfoCharlesM commented Mar 16, 2021

I'm still facing the issue on this stackblitz @yigitfindikli is it normal ?
https://stackblitz.com/edit/primeng-treetableedit-demo-c2brq1?file=src/app/app.component.html

When you open the stackblitz's console and click on a cell then on another you only have two "Init" and no "Complete" between

@InfoCharlesM
Copy link

@yigitfindikli could you please give me an answer ?

@yigitfindikli
Copy link
Member

@InfoCharlesM You need to use v11.3.1 or higher.

@yigitfindikli yigitfindikli added LTS-FIXED-10.1.2 Fixed in PrimeNG LTS 10.1.2 LTS-FIXED-9.2.8 Fixed in PrimeNG LTS 9.2.8 and removed LTS-PORTABLE labels May 7, 2021
yigitfindikli added a commit that referenced this issue May 7, 2021
@InfoCharlesM
Copy link

InfoCharlesM commented May 10, 2021

@InfoCharlesM You need to use v11.3.1 or higher.
@yigitfindikli

The stackbliz on v11.3.1 produces the same problem !

"primeng": "^11.3.1"

https://stackblitz.com/edit/primeng-treetableedit-demo-c2brq1?file=package.json

Edit : even with "primeng": "^11.4.0" the error is still there

@Fakerinc
Copy link

same here. I still have this problem.
onEditComplete event ist not fired when clicking another cell.

@gayatriraichandani
Copy link

It's still not working. Any idea when will it be available?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LTS-FIXED-9.2.8 Fixed in PrimeNG LTS 9.2.8 LTS-FIXED-10.1.2 Fixed in PrimeNG LTS 10.1.2 Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants