Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InputTextArea, FloatLabel and Initial State #9607

Closed
lazyeye73 opened this issue Dec 3, 2020 · 0 comments
Closed

InputTextArea, FloatLabel and Initial State #9607

lazyeye73 opened this issue Dec 3, 2020 · 0 comments
Assignees
Labels
LTS-FIXED-9.2.1 Fixed in PrimeNG LTS 9.2.1 LTS-FIXED-10.0.6 Fixed in PrimeNG LTS 10.0.6 Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@lazyeye73
Copy link

I'm submitting a ...

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Current behavior
If an InputTextarea is wrapped in a FloatLabel and the InputTextarea has an initial value, the FloatLabel appears within the bounds of the rendered textarea control instead of floating above where it should be.

Expected behavior
The FloatLabel should appear above the rendered textarea control if there is an initial value set in the InputTextarea, but the "p-filled" class is not being added to the InputTextarea.

Minimal reproduction of the problem with instructions
https://github-v5s7kb.stackblitz.io

  • Angular version: 10.2.3+

  • PrimeNG version: 10.0.3+

  • Browser: all

  • Language: TypeScript 4.0.5

Code Fix
This can be fixed by adding the following code to the component (which is similar to how the InputText component works):

    ngDoCheck() {
        this.updateFilledState();
    }
@yigitfindikli yigitfindikli self-assigned this Dec 4, 2020
@yigitfindikli yigitfindikli added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Dec 4, 2020
@yigitfindikli yigitfindikli added this to the 11.0.1 milestone Dec 4, 2020
@yigitfindikli yigitfindikli added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working LTS-PORTABLE and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Dec 4, 2020
@yigitfindikli yigitfindikli added LTS-FIXED-10.0.6 Fixed in PrimeNG LTS 10.0.6 LTS-FIXED-9.2.1 Fixed in PrimeNG LTS 9.2.1 LTS-PORTABLE and removed LTS-PORTABLE labels Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LTS-FIXED-9.2.1 Fixed in PrimeNG LTS 9.2.1 LTS-FIXED-10.0.6 Fixed in PrimeNG LTS 10.0.6 Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants