Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messages 2way binding is not working #9623

Closed
Ottani opened this issue Dec 7, 2020 · 0 comments
Closed

Messages 2way binding is not working #9623

Ottani opened this issue Dec 7, 2020 · 0 comments
Assignees
Labels
LTS-FIXED-10.0.8 Fixed in PrimeNG LTS 10.0.8 Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@Ottani
Copy link
Contributor

Ottani commented Dec 7, 2020

I'm submitting a ... (check one with "x")

[X] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)
https://github-6elzxx.stackblitz.io

Current behavior
When not using the MessageService, the "remove" icon is not updating the underlying messages array

Expected behavior
When removing a message from the p-messages component, the 2 way binding should update the array

Minimal reproduction of the problem with instructions
https://github-6elzxx.stackblitz.io

  1. Click the button to add a message to the array
  2. Remove the message
  3. Click the button again, all messages are displayed again
  • Angular version: 10.X
  • PrimeNG version: 10.X
  • Language: [TypeScript]
Ottani added a commit to Ottani/primeng that referenced this issue Dec 7, 2020
Emitting the event after removing a message
@yigitfindikli yigitfindikli self-assigned this Dec 8, 2020
@yigitfindikli yigitfindikli added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Dec 8, 2020
@yigitfindikli yigitfindikli added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Dec 29, 2020
@yigitfindikli yigitfindikli added this to the 11.1.0 milestone Dec 29, 2020
@yigitfindikli yigitfindikli added LTS-PORTABLE LTS-FIXED-10.0.8 Fixed in PrimeNG LTS 10.0.8 and removed LTS-PORTABLE labels Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LTS-FIXED-10.0.8 Fixed in PrimeNG LTS 10.0.8 Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

2 participants