Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Globally configure p-calendar firstDayOfWeek #9635

Closed
chrizy opened this issue Dec 9, 2020 · 6 comments
Closed

Globally configure p-calendar firstDayOfWeek #9635

chrizy opened this issue Dec 9, 2020 · 6 comments
Assignees
Labels
LTS-FIXED-11.4.10 Fixed in PrimeNG LTS 11.4.10 LTS-FIXED-12.2.5 Fixed in PrimeNG LTS 12.2.5 Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@chrizy
Copy link

chrizy commented Dec 9, 2020

[ ] bug report => Search github for a similar issue or PR before submitting
[X ] feature request => Please check if request is not on the roadmap already

Currently I have to set the firstDayOfWeek in every instance of p-calendar (>100 instances), ideally, I’d like to be able to set it once either in PrimeNGConfig or the new Translation setting in PrimeNGConfig.

I'm Currently using PrimeNG version: 11.0.0

@yigitfindikli yigitfindikli added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Dec 10, 2020
@miiihi
Copy link

miiihi commented Dec 10, 2020

Right, and this is a breaking change from v10 not mentioned in the migration guide!

Previously the firstDayOfWeek was part of locale, now it's separate. Why? What was the reasoning to separate it?

At least the default should be taken from locale. And then the option to overrride it if you feel that such option is needed.

Indeed, you're introducing breaking changes where there is no need for them. This applies to the calendar locale change too. You could have easily left the locale option and just add the default coming from config translations...

@Seraphe1
Copy link

Was happy to set calendars' config once for our whole app with i18n API, but as we're reaching France here, had to add firstDayOfWeek on our >100 instances too - which I could set once before PrimeNg V10.
I definitely think firstDayOfWeek has its place in PrimeNGConfig

@vardaru
Copy link

vardaru commented Feb 28, 2021

There is no way to set firstDayOfWeek for a p-columnFilter if its type is date. So its is cruicial to have it in PrimeNGConfig

@WillBoig
Copy link

I have to agree with you, not having first day of week in locale is a big deal for us and requires a lot of boilerplate code to achieve what was previously a one time effort

@stedel
Copy link

stedel commented Aug 23, 2021

Any updates on integrating this in PrimeNGConfig or another "configure once" approach?

@jakob-bebop
Copy link

We need this. We bought a licence. Please fix it :-)

@yigitfindikli yigitfindikli added this to the 13.0.3 milestone Dec 10, 2021
@yigitfindikli yigitfindikli self-assigned this Dec 10, 2021
@yigitfindikli yigitfindikli modified the milestones: 13.0.3, 13.0.4 Dec 20, 2021
lco-dev added a commit to lco-dev/primeng that referenced this issue Jan 13, 2022
@yigitfindikli yigitfindikli added LTS-FIXED-12.2.5 Fixed in PrimeNG LTS 12.2.5 LTS-FIXED-11.4.10 Fixed in PrimeNG LTS 11.4.10 and removed LTS-PORTABLE labels Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LTS-FIXED-11.4.10 Fixed in PrimeNG LTS 11.4.10 LTS-FIXED-12.2.5 Fixed in PrimeNG LTS 12.2.5 Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants