Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optionValue backward compatibility issue #9660

Closed
cagataycivici opened this issue Dec 16, 2020 · 2 comments
Closed

optionValue backward compatibility issue #9660

cagataycivici opened this issue Dec 16, 2020 · 2 comments
Assignees
@cagataycivici @yigitfindikli
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
11.1.0-rc.1

Comments

@cagataycivici
Copy link
Member

Screen Shot 2020-12-16 at 11 54 09
@cagataycivici cagataycivici added the Status: Discussion Issue or pull request needs to be discussed by Core Team label Dec 16, 2020
@cagataycivici cagataycivici added this to the 11.0.1 milestone Dec 16, 2020
@cagataycivici cagataycivici self-assigned this Dec 16, 2020
@antsteyer antsteyer mentioned this issue Dec 18, 2020
Closed
@yigitfindikli yigitfindikli modified the milestones: 11.0.1, 11.1.0 Dec 22, 2020
@yigitfindikli yigitfindikli self-assigned this Dec 22, 2020
@yigitfindikli yigitfindikli added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Discussion Issue or pull request needs to be discussed by Core Team labels Dec 23, 2020
@yigitfindikli yigitfindikli modified the milestones: 11.1.0, 11.1.0-rc.1 Dec 23, 2020
@yigitfindikli yigitfindikli reopened this Dec 23, 2020
@cagataycivici cagataycivici reopened this Dec 23, 2020
@cagataycivici cagataycivici self-assigned this Dec 23, 2020
@cagataycivici
Copy link
Member Author

Reopen for review

@cagataycivici cagataycivici reopened this Dec 24, 2020
@cagataycivici cagataycivici changed the title optionValue compatibility issue optionValue backward compatibility issue Dec 24, 2020
@Spaction
Copy link
Contributor

Spaction commented Jan 10, 2021 •
edited
Loading

Not fixed as commented on code review.
This prevent any type of binding data with ngModel with the most basic set-up of dropdown. This can be determined through setting NGModel to the non-default input. Additionally, if you change the dropdown value, the ngModel is always set to undefined
https://stackblitz.com/edit/primeng-dropdown-demo-pte6kg?file=src%2Fapp%2Fapp.component.html

Corrected in #9742

yigitfindikli added a commit that referenced this issue Mar 15, 2021
@yigitfindikli
Merge pull request #9743 from Spaction/master
e526215 
Fixed #9742 - Implemented fix for #9660 prevents finding a value for simple array of options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cagataycivici cagataycivici

@yigitfindikli yigitfindikli

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
11.1.0-rc.1
Development

No branches or pull requests
3 participants
@cagataycivici @yigitfindikli @Spaction