Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p-chip remove event doesn't match documentation #9735

Closed
smistry7 opened this issue Jan 8, 2021 · 0 comments
Closed

p-chip remove event doesn't match documentation #9735

smistry7 opened this issue Jan 8, 2021 · 0 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@smistry7
Copy link
Contributor

smistry7 commented Jan 8, 2021

If you have a PrimeNG PRO Support subscription please post your issue at;

https://pro.primefaces.org

where our team will respond within 4 business hours.

If you do not have a PrimeNG PRO Support subscription, fill-in the report below. Please note that
your issue will be added to the waiting list of community issues and will be reviewed on a first-come first-serve basis, as a result, the support team is unable to guarantee a specific schedule on when it will be reviewed. Thank you for your understanding.

Current Queue Time for Review
Without PRO Support: ~8-12 weeks.
With PRO Support: 1 hour

I'm submitting a ... (check one with "x")

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)
Please demonstrate your case at stackblitz by using the issue template below. Issues without a test case have much less possibility to be reviewd in detail and assisted.

https://stackblitz.com/github/primefaces/primeng-issue-template

Current behavior

The documentation for the new p-chip component is that clicking the X button will trigger the (onRemove) event but have found that it is actually (remove). This caused some confusion and meant i had to look into the source code to find out why my event binding wasn't working.

Expected behavior

Users can use the correctly documented event handler.

Minimal reproduction of the problem with instructions

Any attempt to use a p-chip with use of the remove event handler

What is the motivation / use case for changing the behavior?

Keep the component in line with the documentation.

Please tell us about your environment:

VS Code, Windows 10

  • Angular version: 5.X

Angular 11

  • PrimeNG version: 5.X

PrimeNG 11.1.0-RC1

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

all

  • Language: [all | TypeScript X.X | ES6/7 | ES5]

all

  • Node (for AoT issues): node --version =
@cagataycivici cagataycivici self-assigned this Jan 11, 2021
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Jan 11, 2021
@cagataycivici cagataycivici added this to the 11.1.0 milestone Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants