Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitter property for initial size should be called panelSize on the showcase #9807

Closed
daniel-lang opened this issue Jan 22, 2021 · 0 comments · Fixed by #9808
Closed

Splitter property for initial size should be called panelSize on the showcase #9807

daniel-lang opened this issue Jan 22, 2021 · 0 comments · Fixed by #9808
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@daniel-lang
Copy link
Contributor

I'm submitting a ... (check one with "x")

[ x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)
Please demonstrate your case at stackblitz by using the issue template below. Issues without a test case have much less possibility to be reviewd in detail and assisted.

https://stackblitz.com/github/primefaces/primeng-issue-template

Current behavior
The showcase calls the property to set the initial size of the panels in the splitter component size at some places, panelSize at others. Looking at the source code, the correct name should be panelSize.
When using size, angular complains, since it isn't a known property of p-splitter.

Expected behavior
Correct documentation/showcase and no error.

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?
Correct the documentation. Help people not have angular errors when using the wrong property.

Please tell us about your environment:

  • Angular version: 11.0.6
  • PrimeNG version: 11.1.0
  • Browser: all
  • Language:

  • Node (for AoT issues): node --version = 15.2.1

@yigitfindikli yigitfindikli added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Feb 12, 2021
@yigitfindikli yigitfindikli added this to the 11.2.2 milestone Feb 12, 2021
yigitfindikli added a commit that referenced this issue Feb 12, 2021
fixed #9807  - Splitter property for initial size should be called panelSize on the showcase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants