Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avatar Circle not working #9895

Closed
ProfEibe opened this issue Feb 14, 2021 · 1 comment · Fixed by #9898
Closed

Avatar Circle not working #9895

ProfEibe opened this issue Feb 14, 2021 · 1 comment · Fixed by #9898
Assignees
@yigitfindikli
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
11.2.3

Comments

@ProfEibe
Copy link 

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Croping an Avatar-Image to the shape of an circle is not working.
p-avatar-circle, the css-class with border-radius 50% is only applied to the parent div-container.

If the containing image is in square format, the border-radius of the parent is ignored.

The demo is looking as if it is working because the used images are already in the shape of a circle
@ProfEibe
Copy link
Author

Alternatively "overflow: hidden"; on p-avatar-circle would do it too.

ProfEibe pushed a commit to ProfEibe/primeng that referenced this issue Feb 15, 2021
Fixed primefaces#9895 - Avatar-Images are overflowing circle-shaped p…
9391f7a 
…arent-Div
@ProfEibe ProfEibe mentioned this issue Feb 15, 2021
Merged
@yigitfindikli yigitfindikli added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Feb 15, 2021
@yigitfindikli yigitfindikli added this to the 11.2.3 milestone Feb 15, 2021
@yigitfindikli yigitfindikli self-assigned this Feb 15, 2021
@yigitfindikli yigitfindikli added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Feb 16, 2021
yigitfindikli added a commit that referenced this issue Feb 16, 2021
@yigitfindikli
Merge pull request #9898 from ProfEibe/master
24286e6 
Fixed #9895 - Avatar-Images are overflowing circle-shaped parent-Div
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yigitfindikli yigitfindikli

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
11.2.3
Development

Successfully merging a pull request may close this issue.

Fixed #9895 - Avatar-Images are overflowing circle-shaped parent-Div ProfEibe/primeng
2 participants
@ProfEibe @yigitfindikli