Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add misspell check #10850

Closed
wants to merge 2 commits into from
Closed

Add misspell check #10850

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0681b07
add misspell check
Rotzbua Nov 12, 2021
36f515d
fix typos
Rotzbua Nov 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .github/workflows/typo.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
name: Typo Tests
on: [pull_request]

jobs:
misspell:
name: runner / misspell
runs-on: ubuntu-latest
steps:
- name: Check out code.
uses: actions/checkout@v2

- name: Run misspell with reviewdog
uses: reviewdog/action-misspell@v1
with:
github_token: ${{ secrets.github_token }}
34 changes: 17 additions & 17 deletions CHANGELOG.md
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions src/app/components/chips/chips.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ describe('Chips', () => {
expect(chips.value[0]).toEqual("primeng");
});

it('should use field varaible', () => {
it('should use field variable', () => {
chips.field = "name";
chips.value = [{ 'name': 'primeng' }];
fixture.detectChanges();
Expand All @@ -306,7 +306,7 @@ describe('Chips', () => {
expect(chips.value[0].name).toEqual("primeng");
});

it('should use field varaible (2)', () => {
it('should use field variable (2)', () => {
chips.field = "name.primeng";
chips.value = [{
'name': {
Expand Down
2 changes: 1 addition & 1 deletion src/app/components/tieredmenu/tieredmenu.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ describe('TieredMenu', () => {
expect(hideSpy).toHaveBeenCalled();
});

it('should use popup with diffrent appendTo', () => {
it('should use popup with different appendTo', () => {
tieredmenu.model = [
{
label: 'File',
Expand Down
2 changes: 1 addition & 1 deletion src/app/components/tristatecheckbox/tristatecheckbox.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ describe('TriStateCheckbox', () => {
expect(labelEl.textContent).toContain("Primeng!");
});

it('should change stlye and styleClass', () => {
it('should change style and styleClass', () => {
tristate.styleClass = "Primeng ROCKS!";
tristate.style = { 'height': '300px' };
fixture.detectChanges();
Expand Down
6 changes: 3 additions & 3 deletions src/app/showcase/components/confirmdialog/confirmdialogdemo.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ <h5>Responsive</h5>
<td>dismissableMask</td>
<td>boolean</td>
<td>false</td>
<td>Specifices if clicking the modal background should hide the dialog.</td>
<td>Specifies if clicking the modal background should hide the dialog.</td>
</tr>
<tr>
<td>defaultFocus</td>
Expand Down Expand Up @@ -271,7 +271,7 @@ <h5>ConfirmationService</h5>
<h5>Customization</h5>
<p>Properties of the dialog are defined in two ways, message, icon and header properties can either
be defined using confirm method or declaratively on p-confirmDialog ng-template. If these values are unlikely to change then
declarative approach would be useful, still properties defined in a ng-template can be overriden with confirm method call.</p>
declarative approach would be useful, still properties defined in a ng-template can be overridden with confirm method call.</p>

<p>In addition, buttons at footer section can be customized by passing your own UI, important note to make confirmation work with
a custom UI is defining a local ng-template variable for the dialog and assign accept()-reject() methods to your own buttons.</p>
Expand Down Expand Up @@ -389,7 +389,7 @@ <h5>Properties</h5>
<td>dismissableMask</td>
<td>boolean</td>
<td>false</td>
<td>Specifices if clicking the modal background should hide the dialog.</td>
<td>Specifies if clicking the modal background should hide the dialog.</td>
<tr>
<td>rtl</td>
<td>boolean</td>
Expand Down
2 changes: 1 addition & 1 deletion src/app/showcase/components/dataview/dataviewdemo.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,7 @@ <h5>Properties</h5>
<td>trackBy</td>
<td>Function</td>
<td>null</td>
<td>Function to optimize the dom operations by delegating to ngForTrackBy, default algoritm checks for object identity.</td>
<td>Function to optimize the dom operations by delegating to ngForTrackBy, default algorithm checks for object identity.</td>
</tr>
<tr>
<td>filterBy</td>
Expand Down
4 changes: 2 additions & 2 deletions src/app/showcase/components/dialog/dialogdemo.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,13 +279,13 @@ <h5>Properties</h5>
<td>closeOnEscape</td>
<td>boolean</td>
<td>true</td>
<td>Specifices if pressing escape key should hide the dialog.</td>
<td>Specifies if pressing escape key should hide the dialog.</td>
</tr>
<tr>
<td>dismissableMask</td>
<td>boolean</td>
<td>false</td>
<td>Specifices if clicking the modal background should hide the dialog.</td>
<td>Specifies if clicking the modal background should hide the dialog.</td>
</tr>
<tr>
<td>rtl</td>
Expand Down
4 changes: 2 additions & 2 deletions src/app/showcase/components/dynamicdialog/dynamicdialogdemo.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ <h5>Properties for DynamicDialog</h5>
<td>closeOnEscape</td>
<td>boolean</td>
<td>true</td>
<td>Specifices if pressing escape key should hide the dialog.</td>
<td>Specifies if pressing escape key should hide the dialog.</td>
</tr>
<tr>
<td>baseZIndex</td>
Expand All @@ -230,7 +230,7 @@ <h5>Properties for DynamicDialog</h5>
<td>dismissableMask</td>
<td>boolean</td>
<td>false</td>
<td>Specifices if clicking the modal background should hide the dialog.</td>
<td>Specifies if clicking the modal background should hide the dialog.</td>
</tr>
<tr>
<td>rtl</td>
Expand Down
2 changes: 1 addition & 1 deletion src/app/showcase/components/i18n/i18n.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ <h1>I18N</h1>
<p>The i18n API allows setting translations globally for the components and integration with translation libraries.</p>

<h5>PrimeNGConfig</h5>
<p>A translation is applied using the PrimeNGConfig instance so begin with injecting it. A common location is the application root to initalize the default language used by the components.
<p>A translation is applied using the PrimeNGConfig instance so begin with injecting it. A common location is the application root to initialize the default language used by the components.
English is the default language and <i>setTranslation</i> function is used to change the values by passing a <i>Translation</i> object.</p>

<app-code lang="typescript" ngNonBindable ngPreserveWhitespaces>
Expand Down
2 changes: 1 addition & 1 deletion src/app/showcase/components/inputnumber/inputnumberdemo.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ <h5>Properties</h5>
<td>string</td>
<td>best fit</td>
<td>The locale matching algorithm to use. Possible values are "lookup" and "best fit"; the default is "best fit".
See <a href="https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl#Locale_negotiation">Locale Negotation</a> for details.
See <a href="https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl#Locale_negotiation">Locale Negotiation</a> for details.
</td>
</tr>
<tr>
Expand Down
2 changes: 1 addition & 1 deletion src/app/showcase/components/orderlist/orderlistdemo.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ <h5>Properties</h5>
<td>trackBy</td>
<td>Function</td>
<td>null</td>
<td>Function to optimize the dom operations by delegating to ngForTrackBy, default algoritm checks for object identity.</td>
<td>Function to optimize the dom operations by delegating to ngForTrackBy, default algorithm checks for object identity.</td>
</tr>
<tr>
<td>controlsPosition</td>
Expand Down
6 changes: 3 additions & 3 deletions src/app/showcase/components/picklist/picklistdemo.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,21 +196,21 @@ <h5>Properties</h5>
<td>trackBy</td>
<td>Function</td>
<td>null</td>
<td>Function to optimize the dom operations by delegating to ngForTrackBy, default algoritm checks for object identity. Use sourceTrackBy or targetTrackBy in
<td>Function to optimize the dom operations by delegating to ngForTrackBy, default algorithm checks for object identity. Use sourceTrackBy or targetTrackBy in
case different algorithms are needed per list.
</td>
</tr>
<tr>
<td>sourceTrackBy</td>
<td>Function</td>
<td>null</td>
<td>Function to optimize the dom operations by delegating to ngForTrackBy in source list, default algoritm checks for object identity.</td>
<td>Function to optimize the dom operations by delegating to ngForTrackBy in source list, default algorithm checks for object identity.</td>
</tr>
<tr>
<td>targetTrackBy</td>
<td>Function</td>
<td>null</td>
<td>Function to optimize the dom operations by delegating to ngForTrackBy in target list, default algoritm checks for object identity.</td>
<td>Function to optimize the dom operations by delegating to ngForTrackBy in target list, default algorithm checks for object identity.</td>
</tr>
<tr>
<td>showSourceFilter</td>
Expand Down
2 changes: 1 addition & 1 deletion src/app/showcase/components/sidebar/sidebardemo.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ <h5>Properties</h5>
<td>closeOnEscape</td>
<td>boolean</td>
<td>true</td>
<td>Specifices if pressing escape key should hide the sidebar.</td>
<td>Specifies if pressing escape key should hide the sidebar.</td>
</tr>
</tbody>
</table>
Expand Down
2 changes: 1 addition & 1 deletion src/app/showcase/components/skeleton/skeletondemo.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ <h5>Size</h5>
</app-code>

<h5>Border Radius</h5>
<p>The default border radius of a rectangle is specified by the theme and can be overriden using the <i>borderRadius</i> property.</p>
<p>The default border radius of a rectangle is specified by the theme and can be overridden using the <i>borderRadius</i> property.</p>
<app-code lang="markup" ngNonBindable ngPreserveWhitespaces>
&lt;p-skeleton borderRadius="16px"&gt;&lt;/p-skeleton&gt;
</app-code>
Expand Down
12 changes: 6 additions & 6 deletions src/app/showcase/components/table/tabledemo.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@ <h5>Templates</h5>
rowIndex: Index of the row <br>
columns: Columns collection <br>
expanded: Whether the row is expanded <br>
rowgroup: Wheter the row is rowgroup <br>
rowgroup: Whether the row is rowgroup <br>
rowspan: Row span of the rowgroup
</td>
<td>Content of the tbody element.</td>
Expand Down Expand Up @@ -569,7 +569,7 @@ <h5>Column Grouping</h5>
<h5>Row Group</h5>
<p>Row Grouping comes in two modes. In "subheader" mode, rows are grouped by a header row along with an optional group footer. In addition, the groups can be use with
Expandable Rows too. On the other hand, the "rowspan" mode uses rowspans instead of a header to group rows. <i>groupRowsBy</i>
property defines the field to use in row grouping. Multiple row grouping is available in "rowspan" mode by specifying the <i>groupRowsBy</i> as an array of fields. Sticky Row Group is avaiable with <i>pRowGroupHeader</i> directive.</p>
property defines the field to use in row grouping. Multiple row grouping is available in "rowspan" mode by specifying the <i>groupRowsBy</i> as an array of fields. Sticky Row Group is available with <i>pRowGroupHeader</i> directive.</p>

<p>Example below demonstrates all the grouping alternatives. Note that data needs to be sorted for grouping, which can also be done by the table itself by speficying the sort properties.</p>

Expand Down Expand Up @@ -1296,7 +1296,7 @@ <h5>ColumnFilter Properties</h5>
<td>string</td>
<td>best fit</td>
<td>The locale matching algorithm for "numeric" type. Possible values are "lookup" and "best fit"; the default is "best fit".
See <a href="https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl#Locale_negotiation">Locale Negotation</a> for details.
See <a href="https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl#Locale_negotiation">Locale Negotiation</a> for details.
</td>
</tr>
<tr>
Expand Down Expand Up @@ -1362,7 +1362,7 @@ <h5>Selection</h5>
are provided as optional callbacks. In order to enable this feature, define a <i>selectionMode</i>, bind a selection reference and add <i>pSelectableRow</i> directive
whose value is the rowData to the rows that can be selected. Additionally, if you prefer double-click, use <i>pSelectableRowDblClick</i> directive instead and
to disable selection events on a particular row use <i>pSelectableRowDisabled</i>. In both cases optional
<i>pSelectableRowIndex</i> property is avaiable to access the row index. By default, each row click adds or removes the row from the selection. If you prefer a classic
<i>pSelectableRowIndex</i> property is available to access the row index. By default, each row click adds or removes the row from the selection. If you prefer a classic
metaKey based selection approach, enable <i>metaKeySelection</i> true so that multiple selection or unselection of a row requires metaKey to be pressed. Note that, on touch enabled
devices, metaKey based selection is turned off automatically as there is no metaKey on devices such as mobile phones.</p>

Expand Down Expand Up @@ -1677,7 +1677,7 @@ <h5>TableRadioButton Properties</h5>
<h5>ContextMenu</h5>
<p>Table has exclusive integration with <i>contextmenu</i> component. In order to attach a menu to a table, add <i>pContextMenuRow</i> directive to the rows that can be selected with context menu, define a local template
variable for the menu and bind it to the <i>contextMenu</i> property of the table. This enables displaying the menu whenever a row is right clicked. Optional
<i>pContextMenuRowIndex</i> property is avaiable to access the row index. A separate <i>contextMenuSelection</i>
<i>pContextMenuRowIndex</i> property is available to access the row index. A separate <i>contextMenuSelection</i>
property is used to get a hold of the right clicked row. For dynamic columns, setting <i>pContextMenuRowDisabled</i> property as true disables context menu for that particular row.</p>


Expand Down Expand Up @@ -3139,7 +3139,7 @@ <h5>Properties</h5>
<td>rowTrackBy</td>
<td>Function</td>
<td>null</td>
<td>Function to optimize the dom operations by delegating to ngForTrackBy, default algoritm checks for object identity.</td>
<td>Function to optimize the dom operations by delegating to ngForTrackBy, default algorithm checks for object identity.</td>
</tr>
<tr>
<td>lazy</td>
Expand Down
2 changes: 1 addition & 1 deletion src/app/showcase/components/tree/treedemo.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -729,7 +729,7 @@ <h5>Properties</h5>
<td>trackBy</td>
<td>Function</td>
<td>null</td>
<td>Function to optimize the node list rendering, default algoritm checks for object identity.</td>
<td>Function to optimize the node list rendering, default algorithm checks for object identity.</td>
</tr>
<tr>
<td>indentation</td>
Expand Down
2 changes: 1 addition & 1 deletion src/app/showcase/components/treetable/treetabledemo.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2056,7 +2056,7 @@ <h5>Properties</h5>
<td>rowTrackBy</td>
<td>Function</td>
<td>null</td>
<td>Function to optimize the dom operations by delegating to ngForTrackBy, default algoritm checks for object identity.</td>
<td>Function to optimize the dom operations by delegating to ngForTrackBy, default algorithm checks for object identity.</td>
</tr>
</tbody>
</table>
Expand Down
2 changes: 1 addition & 1 deletion src/app/showcase/components/virtualscroller/virtualscrollerdemo.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ <h5>Properties</h5>
<td>trackBy</td>
<td>Function</td>
<td>null</td>
<td>Function to optimize the dom operations by delegating to ngForTrackBy, default algoritm checks for object identity.</td>
<td>Function to optimize the dom operations by delegating to ngForTrackBy, default algorithm checks for object identity.</td>
</tr>
<tr>
<td>value</td>
Expand Down