Allow resetting of the DataScroller #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It'd be nice to be able to use the DataScroller in such a way that it can reused for different data sets. For example, an infinite scrolling list that's searchable by the user. When the user first arrives on the page, a set of search results appear. The user can then change the search criteria to provider better results for their specific need. The onLazyLoad handler is aware of the search criteria and returns the data accordingly. In order for this to work though, the scroller needs to be reset, so the loaded data starts again at the beginning.
|
Don't we need to call load() after reset() as you clear the dataToRender(). reset just clears the data I from what I see? |
|
Yes, you're right. I realized that last night, I've made the change to call load(). |
cagataycivici
added
the
Type: Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It'd be nice to be able to use the DataScroller in such a way that it can reused for different data sets. For example, an infinite scrolling list that's searchable by the user.
When the user first arrives on the page, a set of search results appear. The user can then change the search criteria to provider better results for their specific need. The onLazyLoad handler is aware of the search criteria and returns the data accordingly. In order for this to work though, the scroller needs to be reset, so the loaded data starts again at the beginning.