Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dropdown/item clicks causing the window to jump #11513

Conversation

crnisc
Copy link
Contributor

@crnisc crnisc commented May 12, 2022

Fixes #11512

Copy link
Contributor

@cetincakiroglu cetincakiroglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Great PR, could you please consider keyboard events and improve your solution?

Thanks for your effort and support!

@crnisc
Copy link
Contributor Author

crnisc commented May 24, 2022

Which keyboard events?

@cetincakiroglu
Copy link
Contributor

Which keyboard events?

Try to press tab and focus on dropdown with your solution

@crnisc
Copy link
Contributor Author

crnisc commented May 24, 2022

Scrolling an input into view when it is focused by tab is default browser behavior. Do we really want to override that? Example (You will need to delete the header from the page if you want to test.)

@cetincakiroglu cetincakiroglu merged commit 6e14f9f into primefaces:master May 25, 2022
@cetincakiroglu
Copy link
Contributor

Hi @crnisc,

Thanks for your effort and support.

Regards

@crnisc crnisc deleted the bugfix/dropdown-window-scrolls-on-click branch May 25, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown | Mouse click when it is partially off the top of the screen causes the page to jump
2 participants