Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(primeng/p-menubar): add customizable autoHide timeout #12355

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

Foprta
Copy link

@Foprta Foprta commented Dec 11, 2022

Fixed #12454

@cetincakiroglu cetincakiroglu added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Dec 20, 2022
@cetincakiroglu cetincakiroglu removed the Status: Pending Review Issue or pull request is being reviewed by Core Team label Jan 4, 2023
@cetincakiroglu
Copy link
Contributor

cetincakiroglu commented Jan 4, 2023

Hi @Foprta,

The pr causes 1 test error. Could you please refactor your code after running "npm run test:headless" or "npm run test" command and fix the issue?

Also, since this is a new feature you need to add new input props to the documentation as well (menubardemo.html)

@cetincakiroglu cetincakiroglu merged commit dcf892c into primefaces:master Jan 18, 2023
@Foprta
Copy link
Author

Foprta commented Jan 18, 2023

Hi, i will add documentation and tests this weekend. Sorry for late response.

@adrienneh99
Copy link

Hello @Foprta and @cetincakiroglu,

This code change is causing the following compilation errors because debounce and filter need to be imported from 'rxjs/operators' instead of simply 'rxjs':

./node_modules/primeng/fesm2020/primeng-menubar.mjs:364:44-52 - Error: export 'debounce' (imported as 'debounce') was not found in 'rxjs'

https://v6.rxjs.dev/api/operators/debounce

./node_modules/primeng/fesm2020/primeng-menubar.mjs:364:90-96 - Error: export 'filter' (imported as 'filter') was not found in 'rxjs'

https://v6.rxjs.dev/api/operators/filter

My current environment:

  • Angular 15.1.1
  • PrimeNG 15.1.0
  • RxJS 6.5.4

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Customizable hide timeout for Menubar on mouse leave
3 participants