Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #3496: Tooltip optionally take a TemplateRef #12805

Merged
merged 17 commits into from
Aug 21, 2023

Conversation

kyjus25
Copy link
Contributor

@kyjus25 kyjus25 commented Mar 23, 2023

Feature

resolves #3496

Summary

Much like https://ng-bootstrap.github.io/#/components/tooltip/examples, pTooltip should take either a string or a Template Ref

Gallery

Screenshot 2023-03-23 at 4 04 15 PM

Feature Requests

Due to company policy, we are unable to accept feature request PRs with significant changes as such cases has to be implemented by our team following our own processes.
Smaller scaled feature implementations such as adding a property to a component will be considered for merging.

@vercel
Copy link

vercel bot commented Mar 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
primeng-ssr-test ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 18, 2023 6:11pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Aug 18, 2023 6:11pm

@kyjus25 kyjus25 changed the title [WIP] Fixed #3496: Tooltip optionally take a TemplateRef Fixed #3496: Tooltip optionally take a TemplateRef Mar 23, 2023
@kyjus25 kyjus25 marked this pull request as ready for review March 23, 2023 20:45
@kyjus25 kyjus25 changed the title Fixed #3496: Tooltip optionally take a TemplateRef Feature #3496: Tooltip optionally take a TemplateRef Mar 23, 2023
@cetincakiroglu
Copy link
Contributor

cetincakiroglu commented Apr 12, 2023

Wow, great feature and PR, thanks for the effort and support!
Could you please resolve the conflicts?

@cetincakiroglu cetincakiroglu self-requested a review April 12, 2023 08:38
@cetincakiroglu cetincakiroglu added Type: New Feature Issue contains a new feature or new component request Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. Status: Discussion Issue or pull request needs to be discussed by Core Team labels Apr 12, 2023
@kyjus25
Copy link
Contributor Author

kyjus25 commented Apr 12, 2023

@cetincakiroglu conflicts resolved! Thanks!!!

@zerowww
Copy link

zerowww commented Jun 16, 2023

Any update about this PR @kyjus25 @cetincakiroglu ? Thanks :)

@cetincakiroglu cetincakiroglu added this to the 16.Future milestone Jun 16, 2023
@kyjus25
Copy link
Contributor Author

kyjus25 commented Jun 16, 2023

@cetincakiroglu @zerowww PR is updated and ready to go

@mertsincan
Copy link
Member

Hi @kyjus25,

Sorry for the delayed response! Could you please update it? Then, I'll merge it asap.

Thanks a lot for your contribution!
Best Regards,

@mertsincan mertsincan removed Type: New Feature Issue contains a new feature or new component request Status: Discussion Issue or pull request needs to be discussed by Core Team labels Aug 18, 2023
@mertsincan mertsincan modified the milestones: 16.Future, 16.2.1 Aug 18, 2023
@kyjus25
Copy link
Contributor Author

kyjus25 commented Aug 18, 2023

@mertsincan Updated!

@mertsincan mertsincan merged commit a9d0355 into primefaces:master Aug 21, 2023
3 of 4 checks passed
@mertsincan
Copy link
Member

Hi @kyjus25,

Thanks a lot for your contribution!

@kyjus25 kyjus25 deleted the feat/tooltip-template branch August 21, 2023 15:12
@mertsincan mertsincan removed the Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. label Aug 26, 2023
@mertsincan mertsincan removed this from the 16.2.1 milestone Aug 26, 2023
@bemes9226
Copy link

for tooltip templateref example in https://stackblitz.com/ need exaple here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Template support for Tooltip
5 participants