Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify refactor selectButton #13010

Merged

Conversation

Kisters-BS
Copy link
Contributor

@Kisters-BS Kisters-BS commented May 9, 2023

Fix #13553 I have refactored the access of optionValue.

@vercel
Copy link

vercel bot commented May 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
primeng-ssr-test ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2023 11:14am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primeng ⬜️ Ignored (Inspect) May 9, 2023 11:14am

@Kisters-BS Kisters-BS changed the title Modify refactor Modify refactor selectButton May 9, 2023
@mertsincan
Copy link
Member

Hi @Kisters-BS,

Thanks a lot for your contribution! Could you please create a Github issue and link it to this PT? Then, I'll merge it asap.

Best Regards,

@mertsincan mertsincan added the Resolution: Needs Issue An issue needs to be created for the pull request label Aug 26, 2023
@mertsincan mertsincan added this to the 16.2.1 milestone Aug 26, 2023
@Kisters-BS
Copy link
Contributor Author

Kisters-BS commented Aug 28, 2023

Hi @mertsincan,

I have created a Github issue and linked it to this pull request.

@mertsincan mertsincan merged commit af79321 into primefaces:master Aug 29, 2023
1 of 4 checks passed
@mertsincan
Copy link
Member

Hi @Kisters-BS,

Thanks a lot for your contribution!

Best Regards,

@mertsincan mertsincan removed this from the 16.2.1 milestone Aug 29, 2023
@mertsincan mertsincan removed the Resolution: Needs Issue An issue needs to be created for the pull request label Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SelectButton: getOptionValue is called twice in onItemClick if multiple is false (single mode)
2 participants