Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 chore(menu.ts): export SafeHtmlPipe class to be able to use it #13219

Merged
merged 1 commit into from
Jun 17, 2023
Merged

Conversation

jhcpeixoto
Copy link
Contributor

@jhcpeixoto jhcpeixoto commented Jun 16, 2023

The SafeHtmlPipe class was not exported, which made it impossible to use it in other components. Exporting the class makes it available for use in other components.

Issue

#13218

…ther components

The SafeHtmlPipe class was not exported, which made it impossible to use it in other components. Exporting the class makes it available for use in other components.
@vercel
Copy link

vercel bot commented Jun 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primeng ⬜️ Ignored (Inspect) Jun 16, 2023 4:55pm

@volvachev
Copy link
Contributor

Hi, can you check it @cetincakiroglu

@borismm3
Copy link

What is the file location where SafeHtmlPipe is to export?

@jhcpeixoto
Copy link
Contributor Author

What is the file location where SafeHtmlPipe is to export?

src/app/components/menu/menu.ts

@cetincakiroglu cetincakiroglu added the good first issue *** Welcome to PrimeNG Family! *** Good issue! label Jun 17, 2023
@cetincakiroglu cetincakiroglu merged commit cd8122e into primefaces:master Jun 17, 2023
1 check passed
@cetincakiroglu cetincakiroglu linked an issue Jun 17, 2023 that may be closed by this pull request
@rpionke
Copy link

rpionke commented Jun 20, 2023

Can we have a quick release with this fix please? it's blocking a lot of people

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue *** Welcome to PrimeNG Family! *** Good issue!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Cannot resolve type entity SafeHtmlPipe to symbol
5 participants