Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #13559 || DropDown filter search not trimming text and search gone empty #13563

Conversation

ashikjs
Copy link
Contributor

@ashikjs ashikjs commented Aug 29, 2023

Addressing issue || #13559

After solution video for details and test result

Video details of test

@vercel
Copy link

vercel bot commented Aug 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
primeng-ssr-test ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2023 10:04am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Aug 29, 2023 10:04am

@ashikjs ashikjs changed the title fix: #13559 || DropDown filter search not trimming text and search sh… fix: #13559 || DropDown filter search not trimming text and search gone empty Aug 29, 2023
@ashikjs
Copy link
Contributor Author

ashikjs commented Aug 29, 2023

@SoyDiego hi, can you check this PR. Thanks advance

@ashikjs
Copy link
Contributor Author

ashikjs commented Aug 29, 2023

@gucal hi, can you please check this PR. Thanks advance

@SoyDiego
Copy link
Contributor

@SoyDiego hi, can you check this PR. Thanks advance

Hi, thanks for your contribution.
Looks good for me. Add to your post the text: "Fix #13559" to link this PR to the issue.
If PrimeNG Team approves, will close automatically the issue.

@gucal gucal merged commit a542e94 into primefaces:master Aug 29, 2023
3 checks passed
@gucal
Copy link
Contributor

gucal commented Aug 29, 2023

Thanks for contribution. PR approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants