Fix button loading issue #13489 #13676
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
| if (this.loading && !this.loadingIcon && iconElement) { | ||
| iconElement.innerHTML = this.spinnerIcon; | ||
| } else if (iconElement?.innerHTML) { |
There was a problem hiding this comment.
This is a personal opinion but always I prefer a simple if instead else if.
It's cleaner for me, but PrimeNG Team will decide :). Thanks for your contribution
if (this.loading && !this.loadingIcon && iconElement) {
iconElement.innerHTML = this.spinnerIcon;
}
if (iconElement?.innerHTML) {
iconElement.innerHTML = '';
}
There was a problem hiding this comment.
Oh for sure, I have zero preference. Just would really like to see this make it in the next release since it's blocking us from upgrading since all of our buttons are use the pButton directive instead of the p-button element.
Though I think to avoid just undoing the loading spinner it would have to be:
if (this.loading && !this.loadingIcon && iconElement) {
iconElement.innerHTML = this.spinnerIcon;
}
if (!this.loading && iconElement?.innerHTML) {
iconElement.innerHTML = '';
}
There was a problem hiding this comment.
I did a PR fixing something similar in pButton and <p-button time ago #13363
Maybe I forgot something and with your code I hope works 100%
Fixes #13489