Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #13722: FileUpload click instead of mouseup #13723

Conversation

balajis-qb
Copy link

@balajis-qb balajis-qb commented Sep 24, 2023

Closes #13722

Here's a summary of the changes made

  • Previously, we were using a generic mouseup event to detect the click event on the FileUpload component
  • I've now refined it to specifically detect left mouse clicks, making our event handling more precise
  • This change ensures that our component responds correctly to left mouse clicks without interfering with other mouse actions.

Please review the code changes, and if everything looks good, consider merging this update. Kindly let me know if any changes required.

@vercel
Copy link

vercel bot commented Sep 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
primeng-ssr-test ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 24, 2023 1:34pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Sep 24, 2023 1:34pm

Copy link
Contributor

@SoyDiego SoyDiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will leave the same comment as in the another PR

I tested and works perfectly but maybe for any reason the developers of PrimeNG are doing that @cetincakiroglu.

You are right @balajis-qb, also if you click with the mousewheel is opening the window to select a file too.

@balajis-qb
Copy link
Author

Hi @SoyDiego / @cetincakiroglu ,

Is there any update on this PR. Do you have any review comments for this PR?

@cetincakiroglu cetincakiroglu added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Nov 8, 2023
@cetincakiroglu cetincakiroglu added this to the 16.8.0 milestone Nov 8, 2023
@cetincakiroglu cetincakiroglu removed the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Nov 8, 2023
@cetincakiroglu cetincakiroglu removed this from the 16.8.0 milestone Nov 8, 2023
@cetincakiroglu cetincakiroglu merged commit 2bb832a into primefaces:master Nov 8, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FileUpload: Input Triggered on Any Mouse Click
3 participants