Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #13993 - Performance update for virtualScroll selection #14013

Merged
merged 3 commits into from
Nov 17, 2023

Conversation

cetincakiroglu
Copy link
Contributor

@cetincakiroglu cetincakiroglu commented Nov 3, 2023

Fixes #13993

  • SelectAllChange event added,
  • selectAll boolean input added

Users can manage the selection state of all items from outside of the component without looping through options array and update selection state which causes browser freeze on select/deselect actions.

Copy link

vercel bot commented Nov 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
primeng-ssr-test ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 17, 2023 8:17am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Nov 17, 2023 8:17am

Copy link

github-actions bot commented Nov 3, 2023

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@github-actions github-actions bot added the Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. label Nov 3, 2023
@cetincakiroglu cetincakiroglu removed the Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. label Nov 3, 2023
Copy link

github-actions bot commented Nov 3, 2023

Thanks a lot for your contribution! But, PR does not seem to fit our code format standards. Please run the 'npm run format' command and commit the changes.

@github-actions github-actions bot added the Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. label Nov 3, 2023
@cetincakiroglu cetincakiroglu removed the Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. label Nov 3, 2023
@cetincakiroglu cetincakiroglu merged commit 1774eba into master Nov 17, 2023
2 of 4 checks passed
Copy link

Thanks a lot for your contribution! But, PR does not seem to fit our code format standards. Please run the 'npm run format' command and commit the changes.

@github-actions github-actions bot added the Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. label Nov 17, 2023
@cetincakiroglu cetincakiroglu deleted the issue-13993 branch November 21, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VirtualScroller performance enhancement for Input Components with selection
1 participant