Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo "seperator" instead of "separator" #14075

Merged
merged 9 commits into from
Nov 22, 2023

Conversation

SoyDiego
Copy link
Contributor

@SoyDiego SoyDiego commented Nov 9, 2023

Fix #14074

Fix typo seperator instead of separator.

Copy link

vercel bot commented Nov 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
primeng-ssr-test ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2023 7:28pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2023 7:28pm

@ashikjs
Copy link
Contributor

ashikjs commented Nov 14, 2023

@SoyDiego Can you fixed conflicts.

@SoyDiego
Copy link
Contributor Author

@SoyDiego Can you fixed conflicts.

Done! :)

@ashikjs
Copy link
Contributor

ashikjs commented Nov 14, 2023

@SoyDiego If you every time merge master branch then it create a log/commit. If you rebase master branch then it will longer generate any log or commit. You can try it, it make git log more clear and clean.

Simple way you can do this just , take pull on your local master branch and checkout you branch then git rebase master btw if you have multiple commit then it also make harder to rebase but for sinagle commit it work like awesome.

@SoyDiego
Copy link
Contributor Author

@SoyDiego If you every time merge master branch then it create a log/commit. If you rebase master branch then it will longer generate any log or commit. You can try it, it make git log more clear and clean.

Simple way you can do this just , take pull on your local master branch and checkout you branch then git rebase master btw if you have multiple commit then it also make harder to rebase but for sinagle commit it work like awesome.

Thanks, I will try next time

@cetincakiroglu cetincakiroglu merged commit 007553f into primefaces:master Nov 22, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix typo "seperator" in all the project
3 participants