fix #11442 numpad decimal separator should support all keyboard layout #14653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
(#11442 #12626)
Users with multiple keyboard layouts may encounter a problem where the NumPad decimal separator changes to match the locale-based decimal separator.
According to the Mozilla Developer Network, the decimal separator for German, Russian, and Ukrainian keyboard layouts is a comma, while for English, it's a dot.
For instance, if a user's system locale is set to English but they occasionally switch to German, Russian, or Ukrainian, they may face confusion. The input number component expects a dot as the decimal separator, but the NumPad's decimal key provides a comma, leading to a common input error.
Solution
To address this issue, I've implemented a solution that consistently captures the NumPad Decimal input as the decimal separator, regardless of the user's keyboard layout or system locale.
Fixes #12626