Fix #14596 - fixes p-dropdown logic for selectedOption and label #14665
Conversation
fixes logic for selectedOption 1) fixes logic for selectedOption 2) uses selectedOption for computing label -- note: issue with virtual scrolling with lazy loading (PrimeNG Demo) as a result keeping original logic for computing label when virtual load (no harm)
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
This pull request also fixes the "second bug" of issue #14367 The first video listed below is running issue #14367's original reproducer(https://stackblitz.com/edit/stackblitz-starters-5fabhi) and "only" demonstrates the second bug defined in issue #14367. DropdownFilterWithTemplateBug.movThe second video listed below is with the changes from this pull request and shows bug 2 of issue #14367 has been fixed DropdownFilterWithTemplateFix.mov |
rosenthalj
changed the title
|
Great to hear that this is fixed, when can we expect this to be merged. Currently it's not included in the 17.5 milestone |
cetincakiroglu
added
the
Status: Pending Review
cetincakiroglu
removed
the
Status: Pending Review
|
Hi @cetincakiroglu it seems this has reintroduced this issue (#14241 (comment)) with reactive forms, & it seems it could be fixed by adding virtual scroll to dropdown, for now we have downgraded to 17.4 , in 17.5 form patchValue or setValue is not working as expected for dropdown most likely due to this PR. |
|
Hi @imaksp Thanks for letting me know, I'll check that. |
Fix #14596
-- note: issue with virtual scrolling with lazy loading (PrimeNG Demo) as a result keeping original logic for computing label when virtual load (no harm)
The following video demonstrates the fix working for the reproducer in issue #The following video demonstrates the fix.
BetterDropdownFilterBugFix.mov