Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(14706): restore addOnTab behavior - allow user to add chip on tab… #14726

Conversation

Cr3aHal0
Copy link
Contributor

@Cr3aHal0 Cr3aHal0 commented Feb 6, 2024

Fixes #14706

Kept the initial behavior which tabbed the user out of the field if addOnTab is not enabled, add new chip otherwise

Copy link

vercel bot commented Feb 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Feb 6, 2024 9:21am

@Cr3aHal0 Cr3aHal0 force-pushed the feature/14706-add-on-tab-restoration branch from 4d0ce56 to 465616b Compare February 6, 2024 09:10
@Cr3aHal0 Cr3aHal0 force-pushed the feature/14706-add-on-tab-restoration branch from 465616b to c41485c Compare February 6, 2024 09:21
Copy link
Contributor

@cetincakiroglu cetincakiroglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to add event.preventDefault() inside the condition. I'll add it now to save time. Could you please test the changes before creating the PR next time

@cetincakiroglu
Copy link
Contributor

Thanks a lot for PR!

@cetincakiroglu cetincakiroglu merged commit 1a5367d into primefaces:master Feb 13, 2024
3 checks passed
cetincakiroglu added a commit that referenced this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

p-chips: [addOnTab] feature has no effect. Tab key should make a chip and keep focus in the text box.
2 participants