Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #14867 - Tab change inkbar for material design theme #14895

Conversation

dobanisola-scottlogic
Copy link
Contributor

Fixes #14867

When the TabMenu is controlled by updating the activeItem property, the updateInkBar() method isn't called hence the reason the inkbar doesn't get updated in the UI.

image

After the fix
image

Copy link

vercel bot commented Feb 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Feb 28, 2024 9:40am

@dobanisola-scottlogic dobanisola-scottlogic changed the title fix tab change inkbar for material design theme Fixed #14867 fix tab change inkbar for material design theme Feb 28, 2024
@dobanisola-scottlogic dobanisola-scottlogic changed the title Fixed #14867 fix tab change inkbar for material design theme Fixed #14867 - Tab change inkbar for material design theme Feb 28, 2024
Copy link
Contributor

@cetincakiroglu cetincakiroglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Huge thanks for the PR and the tests, we appreciate the effort and support!

@cetincakiroglu cetincakiroglu merged commit e5ce636 into primefaces:master Feb 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TabMenu: TabChange doesn't update Inkbar
2 participants